Libsass 3.0.2

[HamptonMakes]

I know we are torturing you all with our weekly release cycle... but...

https://github.com/sass/libsass/releases/tag/3.0.2

[benflodge]

I have been attempting to compile this but am getting the following error:-
node: symbol lookup error: /u2/home/ben.lodge/sass/node-sass/build/Release/binding.node: undefined symbol: _Z13json_mkobjectv

The tests are failing after running

.renderFile(options)
✓ should compile with renderFile


[am11]

@hcatlin, thanks for the heads-up! 😄👍

@benflodge, we will fix this. We need to make some fixes. I have them locally.

@kevva, @andrew, @nschonni, @keithamus, should we address #332 before release vNext? Also, there are couple of new source-map features added by @mgreter that we need to add (in both API and CLI).

[keithamus]

@am11 I'd personally like to see issues like #497 dealt with as a priority over features like #332. I think we should release a new version with libsass 3.0.2 and the new work done around the binaries, and wait for feedback.

[andrew]

I agree with @keithamus, we should get a release out to fix the install issues first

[kevva]

Yeah, d4b8f6b fixes the install issues for most users (unless the binary doesn't work, then they'll have to build it). Is the build stuff (flag issues etc.) fixed?

[keithamus]

@kevva The majority of flag issues I've seen are just users with old versions of GCC. Are there any others?

[kevva]

Hm, not that I'm aware of. So, are we good to go then? How are we with the Windows issue (tests taking forever when installing) @am11? We need to compile some binaries too.

[am11]

Yes. I think we are good to go. Please make sure compile binaries on separate machines / VMs for each architecture. See #511 (comment).

[am11]

@kevva, should I build the Windows binaries again for https://github.com/sass/node-sass-binaries/commits/master, since you pushed some commits to node-sass after sass/node-sass-binaries@c4f9e9c and sass/node-sass-binaries@64c65fd?

[kevva]

Nah, I think we're fine. Those changes has no effect on the binaries.

[am11]

Yup! I can push Linux x64 binaries. Can you do x32 linux? @andrew will take care of Darwin! 💡

[kevva]

Don't have access to a x86 system ~~.

[keithamus]

Virtualbox will "emulate" 32-bit for you. Unfortunately I recently had to hose my 32-bit images from my machine 😦

[kevva]

Yeah, but I haven't got Vagrant etc set up and I'm too lazy to do that ;pPp.

[keithamus]

Does anyone know if we can configure Travis/Appveyor to get us the 32-bit linux binaries?

[andrew]

I can do Linux 32+64 and Mac this afternoon if still needed

[am11]

We can have 64 bit OS, just need 32 bit node.js on Linux (installed one not the standalone one <-- this is important)

[kevva]

@keithamus, AppVeyor is Windows only. Travis runs on 64 bit images. But yeah, we could probably write a script that installs node-32bit on Travis and runs the build + commits the binaries.

[am11]

@andrew Just Linux 32 and Mac. I am building x64 Linux as we speak.. 😄

[am11]

LOL look at this: sass/node-sass-binaries@faa2e3d.. vagrant?

How, why, what da...!

[kevva]

You've probably setup a image with pre-installed git settings?

[am11]

Nah, I installed everything myself. Ruby, Node, Python, GCC. :D

Just had to do git config --global user.email " .. " thingy. But still, it committed with my account so.. Anyway that was crazy, now it's like this: sass/node-sass-binaries@7a2eb55.

[andrew]

Looks like all the binaries have been built for 3.0.2, are we going to wait for #515 to be merged or should we 🚢 a release this evening?

[am11]

I think lets merge #515 and release. #515 is ready and now node-sass-binaries are isolated from the actual npm. (no mode ../node-sass-binaries folder required) 😄

[andrew]

So do we need to tag the node-sass-binaries git repo or something?

[nschonni]

@am11 has the issue of the binaries not being pinned to a release now been resolved?

[am11]

@nschonni, I think we just need to create a tag on node-sass-binaries. Then we need to assign it to this line. This way it will be locked to one set/version of binaries.

[andrew]

Still having issues with linux binaries: #517 (comment)

[andrew]

Finally published a release that appears to work everywhere with libsass 3.0.2: https://www.npmjs.org/package/node-sass/1.2.3

[xzyfer]

Completely missed this. Y'all keep rocking!