-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Un-quoted sass imports are not watched. #1179
Comments
Is it better with .scss maybe? |
Interesting @saper however why would this even matter? File types should be superfluous. That said...I've ran into situations where semicolons and curly braces ARE REQUIRED. which would NOT be SASS but SCSS. /cc @mcantor That said, kinda ironic SASS recommends SCSS instead of SASS. The ruby SASS compiler allows @import foo /* ruby sass */
@import "foo" /* this DOES work with node sass. Not without quotes */ Isn't node sass a port of ruby sass? |
My question was not about what is right or wrong, I just wanted to see if the bug |
I'm not at the right machine to test this, but @saper I'm assuming that switching to .scss would work because it is a syntax error to have unquoted imports in scss format. In this case, the sass parsing process does not throw an error (because unquoted imports are valid indented syntax), but the code that generates the dependency graph seems to be running on different rules. |
Related issue xzyfer/sass-graph#22 |
sass-graph should understand idented syntax better. sass/node-sass#1179
sass-graph should understand idented syntax better. sass/node-sass#1179 https://github.com/sass/sass-graph/issues/22
So it looks like https://github.com/xzyfer/sass-graph does not support indented syntax really. Filed xzyfer/sass-graph#31 |
sass-graph should understand idented syntax better. sass/node-sass#1179 xzyfer#22
Should be fixed after xzyfer/sass-graph#70
|
Fix a few list output edge cases
With this file structure:
And this code:
And this command line:
Making a change in
styles/account.sass
will not trigger a rebuild ofpublic/index.css
.The dependency tree is cached when
node-sass
first runs, so adding quotes does not add a watch bit tostyles/account.sass
until you re-run the command. Don't be fooled by the rebuild triggered when you savestyles/index.sass
after adding quotes.Version info:
The text was updated successfully, but these errors were encountered: