Add missing implementation of sass_importer_set_list_entry. #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewwells
added a commit
to wellington/go-libsass
that referenced
this pull request
May 19, 2015
|
works, awesome! 🏆 |
|
Seems straight forward to me. @mgreter please take a look and pull the trigger. |
|
Since you're here I see no reason not to also add the getter. Can you please do so? |
|
bump @tristanlins |
|
pong @xzyfer :-) |
|
😍 |
xzyfer
added a commit
that referenced
this pull request
Jun 2, 2015
…ction-implementation Add missing implementation of sass_importer_set_list_entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drewwells already mentioned in #1000 (comment) that the implementation of
sass_importer_set_list_entryis still missing. I need this function for my jsass (a java libsass integration) library, so I simply implemented it. :-)