Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspect() should return an unquoted string when passed a quoted string #2826

Closed
nex3 opened this issue Feb 13, 2019 · 1 comment · Fixed by #2874
Closed

inspect() should return an unquoted string when passed a quoted string #2826

nex3 opened this issue Feb 13, 2019 · 1 comment · Fixed by #2874

Comments

@nex3
Copy link
Contributor

nex3 commented Feb 13, 2019

Currently, when LibSass's inspect() function is passed a quoted string, it returns that string as-is. It should instead return an unquoted string that contains the text of the quoted string as it would be written in a Sass file. For example, inspect("a") should return unquote('"a"'), but it currently returns "a".

Originally reported in sass/dart-sass#594.
nex3 added a commit to sass/sass-spec that referenced this issue Feb 13, 2019
@nex3
Add specs for the inspect() function
6645e24 
See sass/libsass#2826
@nex3 nex3 mentioned this issue Feb 13, 2019
Merged
@nex3
Copy link
Contributor Author

nex3 commented Feb 13, 2019

Spec added in sass/sass-spec#1343

nex3 added a commit to sass/sass-spec that referenced this issue Feb 13, 2019
@nex3
Add specs for the inspect() function
8d08513 
See sass/libsass#2826
nex3 added a commit to sass/sass-spec that referenced this issue Feb 13, 2019
@nex3
Add specs for the inspect() function (#1343)
07e62b6 
See sass/libsass#2826
glebm added a commit to sass/sass-spec that referenced this issue Apr 13, 2019
@glebm
+libsass core_functions/inspect/string/quoted
a30a69f 
Refs sass/libsass#2826
@glebm glebm mentioned this issue Apr 13, 2019
Merged
glebm added a commit to glebm/libsass that referenced this issue Apr 13, 2019
@glebm
Fix inspect for quoted strings
807bd53 
Tests: sass/sass-spec#1381
Fixes sass#2826
@glebm glebm mentioned this issue Apr 13, 2019
Merged
glebm added a commit that referenced this issue Apr 15, 2019
@glebm
Fix inspect for quoted strings
e53c7f8 
Tests: sass/sass-spec#1381
Fixes #2826
glebm added a commit to sass/sass-spec that referenced this issue Apr 15, 2019
@glebm
+libsass core_functions/inspect/string/quoted
83dabb2 
Refs sass/libsass#2826
carlosvalle added a commit to GSA/sam-styles that referenced this issue Oct 17, 2019
@carlosvalle
fix: LibSass 3.5.4 inspect() bug
38e6e2c 
inspect() function should return an unquoted string when passed a
quote string - sass/libsass#2826

This bug has been fixed in LibSass 3.6.0 - unfortunatelly node-sass its
having issues updating to 3.6.0
(sass/node-sass#2685)
While we wait for node-sass. We need to make sure that values that we
pass to the utilities mixins are exactly as described in _system-tokens.scss
@carlosvalle carlosvalle mentioned this issue Oct 17, 2019
Merged
carlosvalle added a commit to GSA/sam-styles that referenced this issue Oct 18, 2019
@carlosvalle
fix: LibSass 3.5.4 inspect() bug
8082c1b 
inspect() function should return an unquoted string when passed a
quote string - sass/libsass#2826

This bug has been fixed in LibSass 3.6.0 - unfortunatelly node-sass its
having issues updating to 3.6.0
(sass/node-sass#2685)
While we wait for node-sass. We need to make sure that values that we
pass to the utilities mixins are exactly as described in _system-tokens.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inspect for quoted strings glebm/libsass
1 participant
@nex3