Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible units error is not reported for expressions in interpolants #1804

Closed
xzyfer opened this issue Dec 27, 2015 · 1 comment · Fixed by #1860
Closed

Incompatible units error is not reported for expressions in interpolants #1804

xzyfer opened this issue Dec 27, 2015 · 1 comment · Fixed by #1860
Assignees
@mgreter
Labels
Bug - Confirmed Bug - Should Error Dev - PR Ready Dev - Test Written
Milestone
3.3.3

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2015

Input:

a {
  margin: #{(2px*5in)};
}

Ruby SASS (3.4.19):

Error: 10in*px isn’t a valid CSS value.

Libsass (3.3.2-32-gb2a3):

a {
  margin: 10in*px;
}

Spec added sass/sass-spec#650
@xzyfer xzyfer added this to the 3.4 milestone Dec 27, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Dec 27, 2015
@xzyfer
Add specs for issue 1804
ce355be 
This PR add specs for sass/libsass#1804
@xzyfer xzyfer mentioned this issue Dec 27, 2015
Merged
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Dec 27, 2015
@xzyfer
Add specs for issue 1804
f197f4c 
This PR add specs for sass/libsass#1804
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Dec 27, 2015
@xzyfer
Add specs for issue 1804
d5a13bd 
This PR add specs for sass/libsass#1804
@xzyfer xzyfer mentioned this issue Dec 27, 2015
Closed
@mgreter
Copy link
Contributor

mgreter commented Jan 14, 2016

#1793 is the same issue though, we need to error once we know the output will end up in css.

@mgreter mgreter mentioned this issue Jan 17, 2016
Merged
@mgreter mgreter modified the milestones: 3.3.3, 3.4 Jan 17, 2016
@mgreter mgreter self-assigned this Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgreter mgreter

Labels
Bug - Confirmed Bug - Should Error Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.3.3
Development

Successfully merging a pull request may close this issue.

Implement incompatible unit test for interpolation in eval mgreter/libsass
2 participants
@mgreter @xzyfer