Arglist passed as single argument for varargs improperly getting destructured

[davidkpiano]

Naming issues is hard.

TEST:

@function foo($a, $should-be-empty...) {
  @return length($should-be-empty);
}

@function bar($args...) {
  @return call(foo, $args...);
}

@function args($args...) {
  @return $args;
}

$a: args(1, 2, 3);

test {
  test: bar($a);
}

EXPECTED:

test {
  test: 0;
}

ACTUAL: (LibSass 3.3.1)

test {
  test: 2;
}

[davidkpiano]

@mgreter I think your example works as expected because you're only passing in one argument to args(), instead of three, as in the previous example.

[mgreter]

yep, saw it too, thought nobody had seen it yet, already removed it ... need to do more tests.

[mirisuzanne]

I just ran into this issue today, and wonder if it's the same thing?

$function: 'hsl';
$hue: 360;
$value: (30%, 40%);

.test {
  // This doesn't work in libsass (works in ruby sass)
  background-color: call($function, $hue, $value...);

  // This works great
  $call: join(($function, $hue), $value);
  color: call($call...);
}

// ERROR: required parameter $lightness is missing in call to function hsl on line 7 at column 21

[xzyfer]

Quiet possibly. I'm working on this fix. It'll be in the next release.
On 20 Nov 2015 6:16 am, "E. Miriam Suzanne" [email protected]
wrote:

I just ran into this issue today
http://sassmeister.com/gist/06cc198106af785c61f9, and wonder if it's
the same thing?

$function: 'hsl';$hue: 360;$value: (30%, 40%);
.test { // This doesn't work in libsass (works in ruby sass)
background-color: call($function, $hue, $value...);
// This works great
$call: join(($function, $hue), $value);
color: call($call...);
}
// ERROR: required parameter $lightness is missing in call to function hsl on line 7 at column 21

—
Reply to this email directly or view it on GitHub
#1645 (comment).

[xzyfer]

Spec added sass/sass-spec#621

[xzyfer]

I have a passing branch for this. It's not pretty but it works for now. I've decided to extend this issue encompass "sassdash test suite passing".

All sassdash tests that aren't segfaulting are passing. I think most of the segfaults are due to #1813 so I think we're close.

[xzyfer]

I know it's been a while @mirisuzanne but the usecase you reported last month is also covered by this patch.

[mirisuzanne]

@xzyfer I'm seeing this error again, but only when I call core Sass functions. With custom functions, it works great. Here's a demo showing it successful with a custom function, and again with the hack listed above – but failing (in libsass only) if you unquote the call with a core function:

https://www.sassmeister.com/gist/cd09d650328b8f486a5d3b31c3009225

[mgreter]

@mirisuzanne could you please create a separate issue and if possible a spec test. Looking at the code and inspecting the AST I believe this specific case has never worked in any previous libsass versions. Thanks.