-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-DDEBUG should not add unconditional debug output #1518
Comments
-DDEBUG currently causes libsass to unconditionally produce debug output which may break our tess. Reported upstream as: sass/libsass#1518
-DDEBUG currently causes libsass to unconditionally produce debug output which may break our tess. Reported upstream as: sass/libsass#1518
If compiling using the debug build of node -DDEBUG and -D_DEBUG flags are automatically added. This causes libsass to produce additional debugging output that may interfere with tests. Once this is resolved, this can be reverted. Reported-as: sass/libsass#1518
If compiling using the debug build of node -DDEBUG and -D_DEBUG flags are automatically added. This causes libsass to produce additional debugging output that may interfere with tests. Once this is resolved, this can be reverted. Reported-as: sass/libsass#1518
Not sure if it is really that unreasonable for libsass to produce debug output when I added this to the wish-list ticket, since I think this issue is actually more about a better and more configurable debug build itself. Currently the DEBUG flag only really debugs the extend step and nothing else ... |
I noticed this broke in 3.3.3. I use |
Maybe I'm misunderstanding, and this is not related to the |
I guess it's related and it was unknown to me we already had something for starters in debug.hpp. But I'm still pretty sure this is only used in extend step, so only covers a small bit of what can be debugged (I mostly use debugger.hpp for "on demand" debugging). |
I have
-DDEBUG
in my compiler flags due to building of the debug module of node and it looks likelibsass
generates a lot of debugging output automatically.There should be a runtime option to explicitly set the debug level (default: off) to keep libsass quiet by default.
The text was updated successfully, but these errors were encountered: