Update protocol-version during embedded-host-node release #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
reviewed
Sep 27, 2023
.github/workflows/ci.yml
Outdated
| run: echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT" | ||
| run: | | ||
| echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT" | ||
| echo "protocol_version=$(curl https://raw.githubusercontent.com/sass/sass/HEAD/spec/EMBEDDED_PROTOCOL_VERSION)" | tee --append "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
There's a risk that this will run into quota limits. We should either pass the GitHub token to it, or find a pre-existing action we can use to download a file with token support. (We could also just use actions/checkout but that'll take longer than necessary.)
ntkme
commented
Sep 27, 2023
| run: echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT" | ||
| run: | | ||
| echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT" | ||
| echo "protocol_version=$(curl -fsSL -H "Authorization: Bearer ${{ github.token }}" https://raw.githubusercontent.com/sass/sass/HEAD/spec/EMBEDDED_PROTOCOL_VERSION)" | tee --append "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Note: curl -fsSL is commonly used in scripting:
-f: Fail fast with no output at all on server errors.
-s: Silent or quiet mode. Do not show progress meter or error messages.
-S: When used with -s, --silent, it makes curl show an error message if it fails.
-L: If the server reports that the requested page has moved to a different location (indicated with a Location: header and a 3XX response code), this option will make curl redo the request on the new place.
nex3
approved these changes
Sep 27, 2023
|
Thanks! |
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
Oct 12, 2023
* feature.color-4: (30 commits) Update for `lch()` tests (sass#2108) Add support for relative color syntax (sass#2112) Update for `oklab()` tests (sass#2094) Poke CI Cut a release (sass#2107) Implement first class mixins (sass#2073) Fix a race condition preventing embedded compiler to shutdown after a protocol error (sass#2106) Switch to the GitHub-hosted MacOS ARM64 runner (sass#2103) Update the version of Sass used by the website on release (sass#2102) Bump actions/checkout from 3 to 4 (sass#2088) Bump docker/setup-qemu-action from 2 to 3 (sass#2089) Implement support for the relative color syntax of CSS Color 5 (sass#2098) Rephrase errors for numbers that must be unitless or % (sass#2101) Forbid LLM contributions (sass#2100) Update protocol-version during embedded-host-node release (sass#2097) Deprecate Deprecation.calcInterp (sass#2096) Avoid useless allocations for interpolations without maps (sass#2095) Fix an error during embedded compiler shutdown (sass#2092) Cut a release (sass#2090) Expose the containing URL to importers under some circumstances (sass#2083) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes sass/embedded-host-node#249