Transform all enum-like classes to dart enums #1777

Goodwine · 2022-08-15T23:04:48Z

Upgrades dart sdk to 2.17 in pubspecs to support enums
Transforms all enum-like classes to dart enums
Fixes new linter warnings around new Foo in comments

…esult

lib/src/ast/css/media_query.dart

lib/src/callable/async.dart

lib/src/ast/sass/expression/binary_operation.dart

…new] to refer to constructors instead of [new Myclass], named constructors only had to drop 'new' and they are already pointing to the intended constructor

lib/src/functions/math.dart

Goodwine force-pushed the enumify branch from cccb94c to 22d8c45 Compare August 15, 2022 23:46

Goodwine added 4 commits August 16, 2022 09:24

Transform all enum-like classes to dart enums

e5739cf

Fixes #1746

fix new linter warnings upon upgrading to 2.17

4a47e17

fix changelog version

ac31a1d

hide away null-accepting constructors for ColorFormat and MediaQueryR…

956e279

…esult

Goodwine force-pushed the enumify branch from 479d588 to 2b38e56 Compare August 16, 2022 16:25

oops forgot return statement, yay tests

242c3a9

Goodwine force-pushed the enumify branch from 2b38e56 to 242c3a9 Compare August 16, 2022 16:27

update pubspec versions after merge

e23a922

Goodwine marked this pull request as ready for review August 16, 2022 16:33

Goodwine requested a review from nex3 August 16, 2022 16:33

nex3 requested changes Aug 17, 2022

View reviewed changes

lib/src/ast/css/media_query.dart Outdated Show resolved Hide resolved

lib/src/callable/async.dart Outdated Show resolved Hide resolved

lib/src/ast/sass/expression/binary_operation.dart Show resolved Hide resolved

revert changes to ColorFormat and MediaQueryResults and use [MyClass.…

9ebab9d

…new] to refer to constructors instead of [new Myclass], named constructors only had to drop 'new' and they are already pointing to the intended constructor

Goodwine requested a review from nex3 August 17, 2022 04:16

nex3 approved these changes Aug 17, 2022

View reviewed changes

lib/src/functions/math.dart Outdated Show resolved Hide resolved

Goodwine and others added 2 commits August 17, 2022 14:38

Update math.dart

0f344fc

fix sass_api pubspec and revert changelog changes

f864e2a

Goodwine force-pushed the enumify branch from e1f5fdf to f864e2a Compare August 17, 2022 21:42

Goodwine merged commit 0b8a0f6 into main Aug 17, 2022

Goodwine deleted the enumify branch August 17, 2022 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transform all enum-like classes to dart enums #1777

Transform all enum-like classes to dart enums #1777

Goodwine commented Aug 15, 2022 •

edited

Loading

Transform all enum-like classes to dart enums #1777

Transform all enum-like classes to dart enums #1777

Conversation

Goodwine commented Aug 15, 2022 • edited Loading

Goodwine commented Aug 15, 2022 •

edited

Loading