[node-sass incompatibility] Missing constants: sass.NULL, sass.TRUE and sass.FALSE #977
Assignees
Labels
Comments
chriseppstein
added a commit
to linkedin/eyeglass
that referenced
this issue
Mar 29, 2020
* Upgrade to typescript 3.8 so that we can use `import type` statements. * Removes `node-sass` as a direct dependency. Eyeglass will attempt to require both `node-sass` and `sass` unless a sass engine is explicitly passed as an option. In the case where both are installed, `node-sass` is used. * All import statements to `node-sass` are now `import type` statements which ensures we won't accidently import a concrete aspect of the library into our module's namespace. * Testing infrastructure and updates to run tests against both implementations of Sass. * Ameliorations for incompatibilities between node-sass and dart-sass. * `dart-sass` has different behavior for importers that return both `file` and `contents`. A bug has been filed at sass/dart-sass#975. Note: Custom importers provided to eyeglass from eyeglass addons or applications using eyeglass are insulated from this incompatibility. * `dart-sass` doesn't support functional invocation of sass value types, so a lot of the code changes were to instantiate those classes with `new` instead. (I discussed this with @nex3 a while ago and she indicated that it wasn't an API difference that she intended to support.) Note: Eyeglass addons that wish to support dart-sass will also need to make this change. * `dart-sass` doesn't support the constants `sass.NULL`, `sass.TRUE` and `sass.FALSE`. Instead, the code in eyeglass has been updated to use the constants that are supported by both: `sass.types.Null.NULL`, `sass.types.Boolean.TRUE`, and `sass.types.Boolean.FALSE` respectively. An issue has been filed: sass/dart-sass#977 * `dart-sass` doesn't support the `nested` output style which was the default for node-sass. So all test output has been converted to expect the `"expanded"` output style.
jathak
added a commit
that referenced
this issue
Apr 24, 2020
jathak
added a commit
that referenced
this issue
Apr 24, 2020
jathak
added a commit
that referenced
this issue
Apr 24, 2020
jathak
added a commit
that referenced
this issue
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dart-sass doesn't support the node-sass constants
sass.NULL,sass.TRUEandsass.FALSEas convenience accessors tosass.types.Null.NULL,sass.types.Boolean.TRUE, andsass.types.Boolean.FALSErespectively.The text was updated successfully, but these errors were encountered: