Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing !important in custom property value causes error #260

Closed
xzyfer opened this issue Mar 17, 2018 · 1 comment
Closed

Trailing !important in custom property value causes error #260

xzyfer opened this issue Mar 17, 2018 · 1 comment
Labels
bug

Comments

@xzyfer
Copy link

xzyfer commented Mar 17, 2018

Originally reported in sass/libsass#2590

According to the spec, this is allowed

Note: Custom properties can contain a trailing !important, but this is automatically removed from the property’s value by the CSS parser, and makes the custom property "important" in the CSS cascade. In other words, the prohibition on top-level "!" characters does not prevent !important from being used, as the !important is removed before syntax checking happens.
@xzyfer xzyfer mentioned this issue Mar 17, 2018
Closed
@nex3
Copy link
Contributor

nex3 commented Mar 22, 2018

Yeah, we should allow this.

@nex3 nex3 added the bug label Mar 22, 2018
nex3 added a commit to sass/sass-spec that referenced this issue Mar 22, 2018
@nex3
Allow ! in custom property values
6fa8d9f 
See sass/dart-sass#260
@nex3 nex3 mentioned this issue Mar 22, 2018
Merged
nex3 added a commit that referenced this issue Mar 22, 2018
@nex3
Allow "!" in custom property values
217bab2 
Closes #260
nex3 added a commit to sass/sass that referenced this issue Mar 22, 2018
@nex3
Allow "!" in custom property values
3a247cb 
See sass/dart-sass#260
@nex3 nex3 mentioned this issue Mar 22, 2018
Merged
nex3 added a commit to sass/sass that referenced this issue Mar 22, 2018
@nex3
Allow "!" in custom property values
e13c4d2 
See sass/dart-sass#260
nex3 added a commit to sass/sass that referenced this issue Mar 23, 2018
@nex3
Allow "!" in custom property values (#2492)
df2bfc8 
See sass/dart-sass#260
nex3 added a commit to sass/sass-spec that referenced this issue Mar 23, 2018
@nex3
Allow ! in custom property values (#1236)
10e7afb 
See sass/dart-sass#260
@nex3 nex3 closed this as completed in 4c293f3 Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @xzyfer