Don't emit "deg" for hsl hues (#1885)

sass · Feb 14, 2023 · c8b4cd0 · c8b4cd0
1 parent d2bc710
commit c8b4cd0
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 1.58.1
+
+* Emit a unitless hue when serializing `hsl()` colors. The `deg` unit is
+  incompatible with IE, and while that officially falls outside our
+  compatibility policy, it's better to lean towards greater compatibility.
+
 ## 1.58.0
 
 * Remove sourcemap comments from Sass sources. The generated sourcemap comment

diff --git a/lib/src/visitor/serialize.dart b/lib/src/visitor/serialize.dart
@@ -604,7 +604,6 @@ class _SerializeVisitor
     var opaque = fuzzyEquals(value.alpha, 1);
     _buffer.write(opaque ? "hsl(" : "hsla(");
     _writeNumber(value.hue);
-    _buffer.write("deg");
     _buffer.write(_commaSeparator);
     _writeNumber(value.saturation);
     _buffer.writeCharCode($percent);

diff --git a/pkg/sass_api/CHANGELOG.md b/pkg/sass_api/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 5.0.1
+
+* No user-visible changes.
+
 ## 5.0.0
 
 * **Breaking change:** Instead of a `Tuple`, `findDependencies()` now returns a

diff --git a/pkg/sass_api/pubspec.yaml b/pkg/sass_api/pubspec.yaml
@@ -2,15 +2,15 @@ name: sass_api
 # Note: Every time we add a new Sass AST node, we need to bump the *major*
 # version because it's a breaking change for anyone who's implementing the
 # visitor interface(s).
-version: 5.0.0
+version: 5.0.1
 description: Additional APIs for Dart Sass.
 homepage: https://github.com/sass/dart-sass
 
 environment:
   sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
-  sass: 1.58.0
+  sass: 1.58.1
 
 dev_dependencies:
   dartdoc: ^5.0.0

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.58.0
+version: 1.58.1
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass