Merge pull request #71 from sashamelentyev/feat/responserec

feat: add check status code in httptest.ResponseRecorder
sashamelentyev · Sep 3, 2022 · 57bc8c0 · 57bc8c0
2 parents 1e41542 + c5e07fe
commit 57bc8c0
Show file tree

Hide file tree

Showing 3 changed files with 780 additions and 3 deletions.
diff --git a/pkg/analyzer/analyzer.go b/pkg/analyzer/analyzer.go
@@ -246,7 +246,8 @@ func funArgs(pass *analysis.Pass, x *ast.Ident, fun *ast.SelectorExpr, args []as
 
 // typeElts checks elements of type.
 func typeElts(pass *analysis.Pass, x *ast.Ident, typ *ast.SelectorExpr, elts []ast.Expr) {
-	if x.Name == "http" {
+	switch x.Name {
+	case "http":
 		switch typ.Sel.Name {
 		// http.Request{Method: http.MethodGet}
 		case "Request":
@@ -268,6 +269,16 @@ func typeElts(pass *analysis.Pass, x *ast.Ident, typ *ast.SelectorExpr, elts []a
 				checkHTTPStatusCode(pass, basicLit)
 			}
 		}
+	case "httptest":
+		if typ.Sel.Name == "ResponseRecorder" {
+			if !lookupFlag(pass, HTTPStatusCodeFlag) {
+				return
+			}
+
+			if basicLit := getBasicLitFromElts(elts, "Code"); basicLit != nil {
+				checkHTTPStatusCode(pass, basicLit)
+			}
+		}
 	}
 }
 

diff --git a/pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl b/pkg/analyzer/internal/template/test-httpstatuscode.go.tmpl
@@ -2,7 +2,10 @@
 
 package {{ .PackageName }}
 
-import "net/http"
+import (
+    "net/http"
+    "net/http/httptest"
+)
 
 var (
 {{- range $key, $value := .Mapping }}
@@ -186,3 +189,19 @@ func _() {
     }
 }
 {{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+	_ = httptest.ResponseRecorder{
+		Code: {{ $key }}, // want `"{{ quoteMeta $key }}" can be replaced by {{ quoteMeta $value }}`
+	}
+}
+{{ end -}}
+
+{{ range $key, $value := .Mapping }}
+func _() {
+	_ = httptest.ResponseRecorder{
+		Code: {{ $value }},
+	}
+}
+{{ end -}}