Speed up resolution by approximating unsatisfied names #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Closing, as implemented this isn't right. I think it might be possible to salvage the optimization approach, I'm make another PR once/if I have one that passes the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Creating as a draft PR because it currently causes a lot of test failures. I don't understand yet if that's because this approach is ultimately unsound or just that some of the assumptions about how resolvelib works are broken, but resolvelib still always finds a correct resolution. If anyone has time to assist in understanding these test failures or explaining what they mean that would help, but otherwise I will figure them out.
Using @pradyunsg's https://github.com/pradyunsg/pip-resolver-benchmarks I see a significant resolution time improve of ~5.5x in the pyrax_198 scenario.