Support both & and | for metasets #69
Conversation
frostming
force-pushed
the
bugfix/67-metasets-or
branch
from
d75f7ba
to
118c776
Compare
Codecov Report
@@ Coverage Diff @@
## add-tests-frost #69 +/- ##
==================================================
+ Coverage 54.96% 57.7% +2.74%
==================================================
Files 42 42
Lines 2700 2757 +57
Branches 475 495 +20
==================================================
+ Hits 1484 1591 +107
+ Misses 1100 1024 -76
- Partials 116 142 +26
Continue to review full report at Codecov.
|
frostming
force-pushed
the
bugfix/67-metasets-or
branch
from
118c776
to
9f13589
Compare
frostming
force-pushed
the
bugfix/67-metasets-or
branch
from
66e57d0
to
3166a7c
Compare
| return str(self) == str(other) | ||
|
|
||
| def __lt__(self, other): | ||
| return hash(self) < hash(other) |
There was a problem hiding this comment.
I’m cool with &, |, and bool, but not sure about the others. == could work, but I’m hesitant since it can result in false negative. I don’t get why < is needed at all, and the implementation even less.
There was a problem hiding this comment.
== is used for deduplicating markers, false negatives(if there are any) won't do harm, while false positives will. < is a somewhat dirty hack to make sorting work, but I suspect we need sorting at all.
There was a problem hiding this comment.
I would suggest using a regular function with proper docstring instead (say a.is_identical_to(b)) since == has the potential to be misused in the future. I don’t think in-class sorting makes sense here since the logic is completely arbitrary; it’s better to pass in a custom key= argument when sorting instead.
Fix #68