-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imported patch from old FAQ_3rd_Set branch w/ burnettk #810
Conversation
WalkthroughThe recent updates encompass significant semantic changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 9
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/Support/FAQ.md (3 hunks)
Additional comments: 13
docs/Support/FAQ.md (13)
145-147: The answer in lines 147-150 about resolving Docker Compose issues on M1/M2 Macs in Spiff Arena is helpful. It addresses common concerns and provides alternative solutions like using
wget
. This is a good example of anticipating user needs and offering practical advice.153-155: The answer in lines 155-156 regarding the inability to import external modules in script tasks within Spiff Arena is clear and provides a recommended alternative approach using ServiceTask. This is a good example of guiding users towards the intended use of the platform's features.
163-165: The answer in lines 165-166 about where properties data is stored in Spiff Arena is informative and provides direct links to examples. This is helpful for users looking for concrete examples of how to configure service tasks.
174-176: The guidance provided in line 176 about setting up an OpenID provider using the
start_keycloak
script is straightforward and actionable. It's good that it points users to a specific script that can serve as a starting point for their own setup.195-197: The explanation in lines 197-199 about the collaboration flag in spiff-example-cli is clear and provides context for its use. It's good that it explains the practical application of the feature.
202-204: The answer in lines 204-208 about creating custom tasks or services in SpiffWorkflow is comprehensive and provides multiple options for users. It's well-structured and includes links to resources for further reading, which is beneficial for users seeking to extend the functionality of their workflows.
213-215: The instructions in lines 215-256 about configuring SpiffWorkflow to work with a computer's hostname are detailed and provide step-by-step guidance. This is a thorough explanation that covers various scenarios and configurations, which is very useful for users looking to customize their setup.
263-265: The guidance in lines 265-279 about modeling an approval process in SpiffWorkflow is clear and methodical. It breaks down the process into actionable steps and provides a reference to the documentation for a deep dive, which is helpful for users looking to implement complex workflows.
284-286: The explanation in lines 286-291 about the Timer Start Event and internal scheduler in SpiffWorkflow is informative. It clarifies the role of the internal scheduler and provides a reference to the backend initialization code, which can be useful for users looking to understand the inner workings of the scheduler.
294-296: The answer in lines 296-300 about authentication tokens in SpiffWorkflow is practical and provides troubleshooting steps using browser developer tools. It also points users to the documentation for updates, which is a good practice for keeping users informed.
303-305: The instructions in lines 305-322 about configuring Spiff Arena to run behind a proxy server are comprehensive and address common issues. It provides a detailed approach to troubleshooting and configuring the environment, which is valuable for users facing similar challenges.
325-326: The explanation in lines 326-340 about the script task state behavior in SpiffWorkflow is insightful. It addresses a specific issue and provides a solution, as well as a reference to the documentation for further understanding of task states.
343-345: The answer in lines 345-356 about cycle timer events and event design in SpiffWorkflow is detailed and addresses a specific issue with data inheritance. It also provides a comprehensive overview of event handling within SpiffWorkflow, which is helpful for users designing complex event-driven workflows.
**Q:** I restarted docker-compose, and my process instances in Spiff Arena aren't persistent. How can I ensure they remain after a restart? | ||
|
||
**A:** Make sure you're using the updated "getting started" `docker-compose.yml` file that uses sqlite to persist the database between docker compose restarts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer provided in lines 106-107 about using the updated docker-compose.yml
file is clear and addresses the question about process persistence after a docker-compose restart. However, it would be beneficial to ensure that the link to the updated docker-compose.yml
file is provided or easily accessible in the documentation for users to find.
**Q:** Is it possible to download a process model in Spiff Arena and then re-upload it? | ||
|
||
**A:** Yes, in Spiff Arena, you can download a process model and then re-upload it. However, it's essential to note that all process IDs must be unique across the system. If you're re-uploading a process model, its ID might need to be modified to ensure uniqueness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer in lines 114-115 about the uniqueness of process IDs when re-uploading a process model in Spiff Arena is informative. However, it might be helpful to include a note or a reference to documentation on how to modify the process ID to ensure uniqueness, as this could be a common point of confusion for users.
**Q:** What are the "notification addresses" and "metadata extractions" fields when creating a new process model in Spiff Arena? | ||
|
||
**A:** When creating a new process model in Spiff Arena, the "notification addresses" field is used to specify recipients for notifications related to that process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation of "notification addresses" and "metadata extractions" in lines 120-123 is concise. However, the note about potential future changes to the functionality of "Notification Addresses" is vague. It would be more helpful if it included a reference to where users can stay updated on these changes or provided a timeline for when they might expect the changes to occur.
**Q:** Why doesn't the Spiff Arena frontend always load completely? | ||
|
||
**A:** The issue might arise when the frontend cannot communicate with the backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer in lines 128-129 about the Spiff Arena frontend loading issues is clear and points to recent updates as a solution. It's good that the answer acknowledges a known issue and provides a direction for users to resolve it. However, it would be beneficial to include a reference to the specific version or update that addresses the issue, so users can verify they have the correct one.
**Q:** How do I start a task? What do I need besides BPMN? | ||
|
||
**A:** To start a task, you'll need to have a proper BPMN diagram and a configured environment. The docker compose file, as mentioned on the [spiffworkflow.org](https://www.spiffworkflow.org/posts/articles/get_started/) website, provides a containerized environment for both the API and asynchronous processing. For a more robust production deployment, it's recommended to use separate containers for different functionalities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer in line 171 about starting a task in Spiff Arena is clear but could be enhanced by providing a direct link to the docker compose file mentioned, as this would improve the user experience by making it easier to access the necessary resources.
**Q:** Where can I configure an SMTP server for Spiffworkflow to send email notifications? | ||
|
||
**A:** To configure an SMTP server for email notifications, you can utilize connectors and service tasks within SpiffWorkflow. For instance, connectors can be set up to send notifications to platforms like Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer in lines 181-182 about configuring an SMTP server for email notifications in SpiffWorkflow is somewhat vague. It mentions the use of connectors and service tasks but does not provide specific guidance or links to documentation on how to set up an SMTP server. Providing a direct link to relevant documentation or examples would be more helpful.
**Q:** Is there any way to access the timer event value/expression in my code? | ||
|
||
**A:** Yes, in SpiffWorkflow, you can access timer event values directly from the backend. There are specific sections in the codebase where timer event values are checked and utilized for various functionalities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer in line 186 about accessing timer event values in SpiffWorkflow is correct but lacks detail. It would be beneficial to include a code snippet or a link to a section in the documentation where users can learn more about accessing and using timer event values.
**Q:** How can I create new users for my co-workers in SpiffWorkflow? | ||
|
||
**A:** There are multiple methods to manage this, such as using OpenID or the process model. However, for beginners eager to add a user quickly, you can adjust the 'example.yml' configuration file within the app identified as `` 'SPIFFWORKFLOW_BACKEND_PERMISSIONS_FILE_NAME: "example.yml"`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer in lines 191-192 about creating new users in SpiffWorkflow provides practical advice and points to the example.yml
configuration file. However, it would be more helpful to include a direct link to the example.yml
file, so users can easily find and reference it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/Support/FAQ.md (3 hunks)
Additional comments: 18
docs/Support/FAQ.md (18)
100-100: The answer provided in line 100 is clear and informative, offering a resource for understanding complex approval processes in SpiffWorkflow.
106-106: The answer on line 106 is clear and provides a solution for ensuring process persistence after a docker-compose restart.
114-114: The answer on line 114 clearly addresses the need for unique process IDs when re-uploading a process model in Spiff Arena.
120-120: The answer on line 120 provides a clear explanation of "notification addresses" and "metadata extractions" in Spiff Arena.
128-128: The answer on line 128 acknowledges a known issue with the Spiff Arena frontend and points to recent updates as a solution.
171-171: The answer on line 171 provides clear instructions on starting a task in Spiff Arena, including the need for a proper BPMN diagram and a configured environment.
181-181: The answer on line 181 provides guidance on configuring an SMTP server for email notifications in SpiffWorkflow.
186-186: The answer on line 186 is informative, explaining how to access timer event values in SpiffWorkflow.
191-191: The answer on line 191 provides practical advice on creating new users in SpiffWorkflow and points to the
example.yml
configuration file.197-197: The explanation of the collaboration flag in line 197 is clear and describes its functionality within spiff-example-cli.
205-205: The answer on line 205 provides multiple options for creating custom tasks or services in SpiffWorkflow, which is helpful for users looking to extend functionality.
217-217: The instructions on line 217 for configuring SpiffWorkflow with a computer's hostname are clear and provide a practical example.
265-265: The answer on line 265 offers a step-by-step guide for modeling an approval process in SpiffWorkflow, which is helpful for users with this requirement.
286-286: The explanation on line 286 about how Timer Start Events work in SpiffWorkflow is clear and informative, detailing the role of the internal scheduler.
296-296: The answer on line 296 provides a clear explanation of how authentication tokens are used in SpiffWorkflow.
305-305: The guidance on line 305 for running Spiff Arena behind a proxy server is comprehensive and addresses common configuration issues.
328-328: The answer on line 328 addresses the behavior of script tasks in SpiffWorkflow and provides insights into task state management.
345-345: The answer on line 345 clearly differentiates between internal and external events in SpiffWorkflow and explains how they are managed.
**Q:** I am designing an approval process using SpiffWorkflow. Can SpiffWorkflow handle scenarios where a task should complete | ||
if more than 2 users approve out of 3 assignees? | ||
|
||
**A:** Yes, SpiffWorkflow can handle complex approval processes. The [provided video](https://www.youtube.com/watch?v=EfTbTg3KRqc) link offers insights into managing such scenarios using SpiffWorkflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question on lines 97-98 ends abruptly and may be missing text or context. Please ensure the question is complete for clarity.
Created using changes from #807.
This branch updates the rewrite history from main to remove SpiffWorkflow and bpmn-js-spiffworkflow.
Summary by CodeRabbit