Add Python 3.12/3.13 support for connector proxy #2104
Conversation
📝 WalkthroughWalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
connector-proxy-demo/dev.Dockerfile (2)
1-1: Approve the base image update with a minor suggestion.The update to Python 3.12 aligns well with the PR objective of adding support for newer Python versions. This change will allow the project to leverage the latest features and improvements in Python.
Consider specifying the exact patch version (e.g.,
python:3.12.0-slim) to ensure consistent builds across different environments. This practice helps in reproducing issues and maintaining version parity.Also, note that while the PR objective mentions Python 3.13 support, this image only updates to 3.12. This is appropriate as Python 3.13 is not yet released for production use.
Line range hint
5-7: Consider updating package versions.With the upgrade to Python 3.12, it's worth checking if newer versions of pip, poetry, and pytest-xdist are available and compatible. This ensures that you're taking full advantage of the latest features and bug fixes in these tools.
You can check for the latest versions of these packages on PyPI:
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
connector-proxy-demo/poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
- connector-proxy-demo/dev.Dockerfile (1 hunks)
- connector-proxy-demo/pyproject.toml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- connector-proxy-demo/pyproject.toml
🧰 Additional context used
🔇 Additional comments (1)
connector-proxy-demo/dev.Dockerfile (1)
Line range hint
9-9: Verify script compatibility with Python 3.12.The CMD instruction remains unchanged, which is generally fine. However, given the update to Python 3.12, it's important to ensure that the
run_server_locallyscript is compatible with this new Python version.Please review the script contents and test it thoroughly with Python 3.12 to confirm there are no compatibility issues.
To help verify the script's compatibility, you can run the following command:
✅ Verification successful
Script Compatibility Verified with Python 3.12.
The
run_server_locallyscript is configured to use Python version^3.11, which includes Python 3.12. Additionally, the dependencies managed by Poetry are compatible with Python 3.12.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the contents of the run_server_locally script for potential compatibility issues with Python 3.12 # Test: Display the contents of the run_server_locally script cat ./bin/run_server_locally # Note: Manual review of the output is required to identify potential compatibility issuesLength of output: 87
Script:
#!/bin/bash # Description: Search for the run_server_locally script in the repository fd run_server_locallyLength of output: 112
Script:
#!/bin/bash # Description: Check the contents of the connector-proxy-demo/bin/run_server_locally script for potential compatibility issues with Python 3.12 # Test: Display the contents of the run_server_locally script cat connector-proxy-demo/bin/run_server_locallyLength of output: 458
Script:
#!/bin/bash # Description: Check the Python version specified in pyproject.toml for compatibility with Python 3.12 # Test: Display the contents of pyproject.toml cat connector-proxy-demo/pyproject.tomlLength of output: 1055
Bumps
spiffworkflow-proxyand ups the docker image to 3.12.Summary by CodeRabbit
connector-awsdependency in the project configuration file.