make TaskDataReference do something #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards making task data work more like the script engine. Ideally, users would be able to extend a data spec to customize how task and workflow data is stored and retrieved, and would be similar to @jbirddog 's work on datastores. The existing dictionary mechanism (which would remain the default) works fine for simple data but is insufficient for large or complex data.
There are a few other places where code would have to be updated to use this, but would require a serialization migration to do it properly. The migration would be very simple, but I don't want to introduce it between creating a release candidate and a release.
The bigger obstacle is the parser -- you could extend the data spec, but there is no way to tell the parser to use it, and adding such a mechanism to the existing parser would be onerous.