Bug/service task variable #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
burnettk
approved these changes
Sep 23, 2022
danfunk
requested changes
Sep 29, 2022
There was a problem hiding this comment.
We may need to require folks to quote their values if they want to include strings - but having good error messages here is going to be critical -- we need to fail fast and clean - and explain that you misspelled "my_ver" and you meant to say "my_var", and not just pass along the string "my_ver" to the service, where the failure is going to make little sense to anyone.
| param['value'] = task.workflow.script_engine.evaluate(task, | ||
| param['value']) | ||
| except: | ||
| pass |
There was a problem hiding this comment.
I worry about swallowing an error here - it may make debugging a problem with parameters very hard to track down. If someone misspells a variable name, how will they now what was wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported by natalia/popster where a variable from a script task was not being evaluated properly for use in the service task. I had a bad feeling about that
reprthat was on main. This fixes the issue and uses the bpmn diagram from staging as the test case.