Feature/improved script engine #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the script engine, allowing the DMN-related work to happen in the DMN engine, with the work done by the script engine being evaluation and execution.
Expression evaluation and script execution now takes place separately from the interface with the workflow, in
_evaluateand_executemethods. Additionally, scripts are started when the task becomes ready and moved into a waiting state until completed, to allow asynchronous engines to implemented more easily. These changes should make it a lot easier to implement custom script engines.As a side note, I discovered that most of our FEEL tests were not actually using the
FeelLIkeScriptEngine; I've corrected this.