Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bpmn io spec #190

Merged
merged 9 commits into from
Jul 13, 2022
Merged

Feature/bpmn io spec #190

merged 9 commits into from
Jul 13, 2022

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Jul 8, 2022

This PR

  1. Adds the ability to define data inputs and outputs on a process.
  2. Adds the ability to define data objects and references to them
  3. Support for Spiff pre/postscript extensions.

burnettk
burnettk approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@burnettk burnettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're updating SPIFFWORKFLOW_MODEL_NS, we might hold on the new value before merging.

SpiffWorkflow/bpmn/specs/BpmnProcessSpec.py
raise WorkflowDataException(my_task, data_input=self)
my_task.data[self.name] = deepcopy(my_task.workflow.data[self.name])

def set(self, my_task):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might make it more readable for some of these method names (get, set, and copy) to be longer, from my perspective.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

91.0% 91.0% Coverage
0.0% 0.0% Duplication

@danfunk danfunk merged commit 5d76ba3 into main Jul 13, 2022
@danfunk danfunk deleted the feature/bpmn-io-spec branch August 19, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnettk burnettk burnettk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@essweine @burnettk @danfunk