Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Work Together On.." dropdown list contains only the first project #469

Closed
m273d15 opened this issue Mar 13, 2019 · 4 comments
Closed

The "Work Together On.." dropdown list contains only the first project #469

m273d15 opened this issue Mar 13, 2019 · 4 comments
Labels
Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Aspect: GUI Issues specific to the Saros GUI Type: Bug Issue that describes an unintended behavior of Saros

Comments

@m273d15
Copy link
Contributor

m273d15 commented Mar 13, 2019

The dropdown list of the "Work Together On.." context menu in the saros view contains only the first project instead of all available projects.

E.g. If the project tree contains three projects A-project, B-project, C-project only the project A-project is contained in the dropdown list.
@m273d15 m273d15 added Type: Bug Issue that describes an unintended behavior of Saros Aspect: GUI Issues specific to the Saros GUI Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) labels Mar 13, 2019
@m273d15 m273d15 mentioned this issue Mar 13, 2019
Closed
13 tasks
@srossbach
Copy link
Contributor

https://stackoverflow.com/questions/12315749/e4-dynamic-menu-contributions

@srossbach
Copy link
Contributor

https://github.com/saros-project/saros/blob/master/eclipse/src/saros/ui/menuContributions/StartSessionWithProjects.java is the affected class. I checked the class and the logic is working. So I guess it is an Eclipse issue that does not properly show the context menu entries.

@m273d15
Copy link
Contributor Author

m273d15 commented Apr 11, 2019

It seems as if #473 is required before using dynamic context menus in the eclipse 4 environment. For now I would remove the dynamic list and replace the "Work Together On.." entry with a "Share Project(s).." entry that opens the dialog for sharing projects.

@m273d15 m273d15 mentioned this issue May 13, 2019
Merged
@m273d15
Copy link
Contributor Author

m273d15 commented May 16, 2019

Implemented a workaround in #521. After migrating to e4 we should re-implemented these dynamic menus!

@m273d15 m273d15 closed this as completed May 16, 2019
srossbach added a commit that referenced this issue Jul 28, 2019
@srossbach
[FIX][E] Fixes #469 by reintroduces missing context menu
6c7aef4 
This time without the plugin.xml magic. The context menu was only shown
when a JID was selected which is only the case when you select something
in the Saros View, to be more specific in the roster.

Restores the original behavior, the only thing that is missing is the
tooltip for the menu entry.
srossbach added a commit that referenced this issue Jul 29, 2019
@srossbach
[FIX][E] Fixes #469 by reintroduces missing context menu
c380ade 
This time without the plugin.xml magic. The context menu was only shown
when a JID was selected which is only the case when you select something
in the Saros View, to be more specific in the roster.

Restores the original behavior, the only thing that is missing is the
tooltip for the menu entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Aspect: GUI Issues specific to the Saros GUI Type: Bug Issue that describes an unintended behavior of Saros
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m273d15 @srossbach