Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-user sessions in Saros/I #1057

Closed
2 of 3 tasks
tobous opened this issue Jul 2, 2020 · 0 comments · Fixed by #1099 or #1103
Closed
2 of 3 tasks

Support multi-user sessions in Saros/I #1057

tobous opened this issue Jul 2, 2020 · 0 comments · Fixed by #1099 or #1103
Assignees
@tobous
Labels
Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) State: In Progress Issue is being worked on Type: Feature Issue that describes a new behavior of Saros
Milestone
Saros/I Release NEXT

Comments

@tobous
Copy link
Member

tobous commented Jul 2, 2020 •
edited
Loading

Currently, Saros/I only allows 2-user sessions (the host and one client). This should be expanded to support multi-user sessions with 5 (or more if you don't mind them all having the same color) users.

From my guess, this is only a UI issue. I don't see any problem from the standpoint of the internal logic.

After this functionality has been added, the base sharing logic has to be tested/reevaluated to ensure that it still works correctly in multi-user setups and does not introduce any unintended side-effects/unwanted behaviors.

The following is a (non-exhaustive) list of steps that are required for this to happen:

  • Allow adding new users to a running session. To do this, the contact context menu has to be updated when there already is a session to just add the user to it. (Currently, the logic still tries to create a new session in such cases, even though there already is a running session.)
  • Add the functionality to remove users from the session. This can easily be done by expanding the options shown in the contact context menu.
  • (Dependent on Allow sharing multiple resource trees/reference points in Saros/I #1056) Expand the wizard to start a resource negotiation to also allow the user to choose which contact to start the negotiation with. This allows for an easier creation of multi-user session than having to manually add every user after the fact.
@tobous tobous added Type: Feature Issue that describes a new behavior of Saros Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) State: Open Confirmed issue not currently being worked on labels Jul 2, 2020
tobous added a commit that referenced this issue Nov 9, 2020
@tobous
[UI][I] Add option to add user to existing session
f830ca1 
Adds the option to add a user to an existing session. This enables
multi-user session support for Saros/I.

Resolves issues where the pop-up dialog to create a new session was
still displayed, even if the local user is already part of a session.
Ensures that the dialog is only displayed when there is a valid option
and that the correct option is displayed.

Copies the icon used for the option to add users to the session from
the Eclipse package.

Resolves part of #1057.
@tobous tobous mentioned this issue Nov 9, 2020
Merged
@tobous tobous linked a pull request Nov 9, 2020 that will close this issue
Add multi-user session support #1099
Merged
tobous added a commit that referenced this issue Nov 9, 2020
@tobous
[UI][I] Add option to add user to existing session
610eabd 
Adds the option to add a user to an existing session. This enables
multi-user session support for Saros/I.

Resolves issues where the pop-up dialog to create a new session was
still displayed, even if the local user is already part of a session.
Ensures that the dialog is only displayed when there is a valid option
and that the correct option is displayed.

Copies the icon used for the option to add users to the session from
the Eclipse package.

Resolves part of #1057.
tobous added a commit that referenced this issue Nov 9, 2020
@tobous
[UI][I] Add option to kick user from session
594b13b 
Adds the option for the host to kick users from the session.

Adds an icon to the pop-up follow mode option.

Moves the messages shown to the user in SessionPopMenu to
IntellijMessages.properties.

Copies the icon to kick a session participant from the Eclipse package.

Resolves part of #1057.
@tobous tobous self-assigned this Nov 9, 2020
@tobous tobous added State: In Progress Issue is being worked on and removed State: Open Confirmed issue not currently being worked on labels Nov 9, 2020
@tobous tobous added this to the Saros/I Release NEXT milestone Nov 9, 2020
tobous added a commit that referenced this issue Nov 11, 2020
@tobous
[UI][I] Add option to add user to existing session
ba951d3 
Adds the option to add a user to an existing session. This enables
multi-user session support for Saros/I.

Resolves issues where the pop-up dialog to create a new session was
still displayed, even if the local user is already part of a session.
Ensures that the dialog is only displayed when there is a valid option
and that the correct option is displayed.

Copies the icon used for the option to add users to the session from
the Eclipse package.

Resolves part of #1057.
tobous added a commit that referenced this issue Nov 11, 2020
@tobous
[UI][I] Add option to kick user from session
0831023 
Adds the option for the host to kick users from the session.

Adds an icon to the pop-up follow mode option.

Moves the messages shown to the user in SessionPopMenu to
IntellijMessages.properties.

Copies the icon to kick a session participant from the Eclipse package.

Resolves part of #1057.
tobous added a commit that referenced this issue Nov 11, 2020
@tobous
[UI][I] Add option to add user to existing session
4a39091 
Adds the option to add a user to an existing session. This enables
multi-user session support for Saros/I.

The logic is implemented in InviteToSessionMenu.

Cleans up the logic spawning contact menus.

Resolves issues where the pop-up dialog to create a new session was
still displayed, even if the local user is already part of a session.
Ensures that the dialog is only displayed when there is a valid option
and that the correct option is displayed.

Copies the icon used for the option to add users to the session from
the Eclipse package.

Resolves part of #1057.
tobous added a commit that referenced this issue Nov 11, 2020
@tobous
[UI][I] Add option to kick user from session
05b8f21 
Adds the option for the host to kick users from the session.

Adds an icon to the pop-up follow mode option.

Moves the messages shown to the user in SessionPopMenu to
IntellijMessages.properties.

Copies the icon to kick a session participant from the Eclipse package.

Resolves part of #1057.
tobous added a commit that referenced this issue Nov 11, 2020
@tobous
[UI][I] Add option to kick user from session
e954d49 
Adds the option for the host to kick users from the session.

Adds an icon to the pop-up follow mode option.

Moves the messages shown to the user in SessionPopMenu to
IntellijMessages.properties.

Copies the icon to kick a session participant from the Eclipse package.

Resolves part of #1057.
@tobous tobous linked a pull request Nov 12, 2020 that will close this issue
Add multi-user session support #1103
Merged
tobous added a commit that referenced this issue Nov 12, 2020
@tobous
[UI][I] Add option to add user to existing session
fc0184c 
Adds the option to add a user to an existing session. This enables
multi-user session support for Saros/I.

The logic is implemented in InviteToSessionMenu.

Cleans up the logic spawning contact menus.

Resolves issues where the pop-up dialog to create a new session was
still displayed, even if the local user is already part of a session.
Ensures that the dialog is only displayed when there is a valid option
and that the correct option is displayed.

Copies the icon used for the option to add users to the session from
the Eclipse package.

Resolves part of #1057.
tobous added a commit that referenced this issue Nov 12, 2020
@tobous
[UI][I] Add option to kick user from session
866dc5c 
Adds the option for the host to kick users from the session.

Adds an icon to the pop-up follow mode option.

Moves the messages shown to the user in SessionPopMenu to
IntellijMessages.properties.

Copies the icon to kick a session participant from the Eclipse package.

Resolves part of #1057.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobous tobous

Labels
Area: IntelliJ Issue affecting Saros for IntelliJ (Saros/I) State: In Progress Issue is being worked on Type: Feature Issue that describes a new behavior of Saros
Projects
None yet
Milestone
Saros/I Release NEXT
1 participant
@tobous