Add __getitem__ to XPathLocator
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1troll
requested review from
ron8mcr,
TheSuperiorStanislav and
NikAzanov
as code owners
QuirrelForU
requested changes
Feb 10, 2025
| # To avoid ugly locators with `...)[last() - 0]` | ||
| query += "[last()]" | ||
| else: | ||
| query += f"[last() - {abs(index + 1)}]" |
There was a problem hiding this comment.
It seems -index+1 is enough for this case, cuz due to conditions index can only be (-inf;-2]
There was a problem hiding this comment.
Yeah, we can
But I just decided to use the current variant because if we leave the -index+1 option, we get a less readable query:
index = -2
f"[last() - {abs(index + 1)}]" --> [last() - 1] "
f"[last(){index + 1}]" --> [last()-1] " <-- *no spaces, harder to read
QuirrelForU
approved these changes
Feb 10, 2025
TheSuperiorStanislav
approved these changes
Feb 10, 2025
M1troll
force-pushed
the
feature/add-getting-by-index-to-xpathlocator
branch
from
e886b39 to
333d98d
Compare
Add ability to get related xpath locators by index
M1troll
force-pushed
the
feature/add-getting-by-index-to-xpathlocator
branch
from
333d98d to
c6554f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to get related xpath locators by index