-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adafruit bno055 update + added position configs #124
base: master
Are you sure you want to change the base?
Changes from 19 commits
c1c0723
735c0b3
7b522a1
e01a593
ccb22b8
c9febf0
e0a5e21
69b2545
53b8147
89bdb3e
9c57dc2
6d2e3e1
2ce4d1d
a96150d
702b57d
63b8c44
4e0d1bf
4cc5d12
420e11a
1f9dde7
89028f8
5bf933f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
name=Adafruit BNO055 | ||
version=1.0.6 | ||
version=1.1.6 | ||
author=Adafruit <[email protected]> | ||
maintainer=Adafruit <[email protected]> | ||
sentence=Library for the Adafruit BNO055 Absolute Orientation Sensor. | ||
paragraph=Designed specifically to work with the Adafruit BNO055 Breakout, and is based on Adafruit's Unified Sensor Library. | ||
category=Sensors | ||
url=https://github.com/adafruit/Adafruit_BNO055 | ||
architectures=* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,22 +27,35 @@ | |
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
THE SOFTWARE. | ||
*/ | ||
/* horizontal top (KBox or sensor) | ||
__________________ | ||
/ o /| | ||
/ / / | ||
Left Side / BNO055 / / Right Side | ||
/ vertical top / / | ||
/_________________/ / | ||
|________________ |/ | ||
|
||
horiz. bottom (KBox or sensor) | ||
*/ | ||
|
||
#pragma once | ||
|
||
enum IMUMounting { | ||
VerticalStbHull, | ||
VerticalPortHull, | ||
VerticalTopToBow, | ||
//VerticalTopToStern, | ||
HorizontalLeftSideToBow, | ||
//HorizontalRightSideToBow | ||
verticalRightSideToBow, // KBox mounted on port hull | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why have two options that are the same thing? It looks like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes if I remember right, it is the same. If you like it in principle and if it is easy for you to change, please do so. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like the new naming and I think it's good to remove the old one to keep the more explicit one. 👍 |
||
verticalLeftSideToBow, // KBox mounted on stb. hull | ||
verticalTopToBow, // KBox mounted on rear bulkhead | ||
verticalBottomToBow, // KBox mounted on front bulkhead, | ||
horizontalTopToBow, | ||
horizontalLeftSideToBow, | ||
horizontalBottomToBow, | ||
horizontalRightSideToBow, | ||
}; | ||
|
||
struct IMUConfig { | ||
bool enabled; | ||
int frequency; | ||
bool enableHdg; | ||
bool enableHeelPitch; | ||
enum IMUMounting mounting = VerticalPortHull; | ||
enum IMUMounting mounting = verticalRightSideToBow; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may need to add
lib_ignore = ${common.incompatible_libs_teensy}
when you merge. Not sure ... Please give it a try. I have added it forenv:host
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid I did some mistake on the last merge of your updates, because
[env:host-teensy36] [env:program-esp] [env:program-esp-teensy36]
are already updated in your uptodate master branch.
It was doubled in the PR by mistake.
did a
git checkout upstream/master platformio.ini
now