Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adafruit bno055 update + added position configs #124
base: master
Are you sure you want to change the base?
Adafruit bno055 update + added position configs #124
Changes from 13 commits
c1c0723
735c0b3
7b522a1
e01a593
ccb22b8
c9febf0
e0a5e21
69b2545
53b8147
89bdb3e
9c57dc2
6d2e3e1
2ce4d1d
a96150d
702b57d
63b8c44
4e0d1bf
4cc5d12
420e11a
1f9dde7
89028f8
5bf933f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have two options that are the same thing? It looks like
verticalPortHull == verticalRightSideToBow
? Or maybe I am missing something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes if I remember right, it is the same.
verticalPortHull
is the "deprecated" naming convention which I believe you have in your config. If you switch to the "more detailed naming convention" then we do not need it anymore.If you like it in principle and if it is easy for you to change, please do so.
Otherwise I think the right way is to merge your new commits, add the
[env:host36]
and delete theverticalPortHull
,verticalStbHull
settings in this PR, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new naming and I think it's good to remove the old one to keep the more explicit one. 👍