Add support for HFE v3 OPCODE_RAND (for Sherston games) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/disc_hfe.c
Outdated
| @@ -289,7 +289,8 @@ static void process_v3_track(mfm_t *mfm, int side) | |||
| break; | |||
|
|
|||
| case HFE_V3_OPCODE_RAND: | |||
| /*Not currently implemented, just add a byte of zeroes*/ | |||
| /* Insert random byte - used for 'weak sector' protection on e.g. Sherston */ | |||
| mfm->track_data[side][wp >> 3] = rand() & 0xFF; | |||
There was a problem hiding this comment.
wp might not be 8-bit aligned at this point.
|
That should fix the alignment issue, @sarah-walker-pcem - sorry for the delay, I've had this fixed locally but forgot to push the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for weak sector emulation when using HFE images as the source.
Fixes Sherston games with weak sector protection
These still won't work from SCP source images - chances are those probably need to have images of multiple revolutions and Arculator will need to play them in sequence. For now it's easier to just use HFEs.