This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
fix: make sure document is defined #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
suggested changes
Feb 12, 2018
src/styles.ts
Outdated
| const container = document.querySelector('head'); | ||
| if (!container) { | ||
| throw new Error('<head> tag not found'); | ||
| if (typeof document !== 'undefined') { |
There was a problem hiding this comment.
Would be nice to use an early return here instead of wrapping the whole thing in a condition.
|
@sapegin Updated as you recommended. |
sapegin
approved these changes
Feb 12, 2018
|
Awesome, merged! Does it fix #4 or something else is needed? |
|
I've not tested if it fully supports SSR |
|
Thanks for merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if global
documentexists to attach styles to.Relates to #4