Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

update ttf2woff2 for node 4+ support #287

Merged
merged 1 commit into from
Nov 10, 2015
Merged

update ttf2woff2 for node 4+ support #287

merged 1 commit into from
Nov 10, 2015

Conversation

fernandopasik
Copy link
Contributor

sapegin added a commit that referenced this pull request Nov 10, 2015
Update ttf2woff2 for node 4+ support.
@sapegin sapegin merged commit bbd10fe into sapegin:master Nov 10, 2015
@sapegin
Copy link
Owner

sapegin commented Nov 10, 2015

Hm, it’s not a support, it’s a requirement. We should require node 4+ for grunt-webfont too.

@nfroidure
Copy link
Collaborator

Not anymore with the last ttf2woff2 update, in fact it is now compatible with at least Node 0.12. In all cases though, when the build fails the emscriten fallback still works.

@fernandopasik
Copy link
Contributor Author

@sapegin can we bump grunt-webfont version and publish to npm also please?

@nfroidure
Copy link
Collaborator

We're about to make it build on windows too nfroidure/ttf2woff2#13 (comment)

Just wait a bit, we'll warn you asap.

@sapegin
Copy link
Owner

sapegin commented Nov 10, 2015

@fernandopasik I’d wait for Windows support too.

@fernandopasik
Copy link
Contributor Author

Oh ok! Thanks @sapegin @nfroidure !

@sapegin
Copy link
Owner

sapegin commented Nov 16, 2015

@nfroidure Hey is it ready? ;-)

@nfroidure
Copy link
Collaborator

Not yet, i'm changing the emscripten build to use bindings and maybe avoid the AVG antivirus warning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants