Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new nova value to scheduler section #2141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added new nova value to scheduler section #2141

wants to merge 1 commit into from

Conversation

GlaciErrDev
Copy link
Contributor

  • New value:
    'reserved_ram_threshold_for_resize'

@joker-at-work
Copy link
Contributor

I don't like the commit-message. It's too generic and one has to click on the PR to even know what's it about. Could we change it to something like Make reserved_ram_threshold_for_resize configurable or something? We can then in the body explain that it's a new scheduler thing for a filter to reserve ram for resize and why we want that filter in the first place.

@joker-at-work
Copy link
Contributor

Wouldn't we also have to add it to the filter to default_filters, to make use of it? Is this another PR? Could you please link those two, if yes?

@GlaciErrDev GlaciErrDev force-pushed the feature/add_reserved_ram_value branch from fcbd202 to 6cc4f12 Compare January 22, 2021 16:06
Make resize_threshold_reserved_ram_percent configurable
3983a11 
  It's a new scheduler option for a Nova filter to reserve ram for resizing
  and it needs to prevent new deployments to happen on a cluster if the RAM
  goes over this threshold.

  This value specifies the minimum free
  percentage of total RAM on a host to be considered as a target host
  when resizing an instance.
@GlaciErrDev GlaciErrDev force-pushed the feature/add_reserved_ram_value branch from 6cc4f12 to 3983a11 Compare January 22, 2021 16:11
joker-at-work
joker-at-work requested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@joker-at-work joker-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker for merging. David hasn't decided, yet, if we want to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker-at-work joker-at-work joker-at-work requested changes

@grandchild grandchild Awaiting requested review from grandchild

@galkindmitrii galkindmitrii Awaiting requested review from galkindmitrii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GlaciErrDev @joker-at-work