Make IPv4 fips syncable on IPv6-only routers #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routers with an IPv6-only gateway can have IPv4 fips. Before this commit, we were passing the unused global ip mask to the StaticNat class, which required us to have an IPv4 gateway address. This is not needed and should make this kind of router syncable again. I am not yet fully sure if IPv4 fips will work on this kind of router, but a sync error is definitely not the way to go there. Either we get this working or we forbid it in a precommit hook.
mutax
approved these changes
Mar 4, 2025
joker-at-work
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routers with an IPv6-only gateway can have IPv4 fips. Before this commit, we were passing the unused global ip mask to the StaticNat class, which required us to have an IPv4 gateway address. This is not needed and should make this kind of router syncable again.
I am not yet fully sure if IPv4 fips will work on this kind of router, but a sync error is definitely not the way to go there. Either we get this working or we forbid it in a precommit hook.