add container files #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuckal777
reviewed
Mar 3, 2025
Comment on lines
+7
to
+8
| RUN git clone https://github.com/sapcc/alertmagnet.git | ||
| WORKDIR /alertmagnet |
There was a problem hiding this comment.
Why no COPY . /alertmagnet together with .dockerignore to exclude any local venvs? 🧐
There was a problem hiding this comment.
If this later runs in a pipeline I rather don't want to explicitly checkout the gh repository beforehand to do the adding.
Also it prohibits adding anything critical to the image which might be floating around locally and has been forgotten in the .dockerignore.
There was a problem hiding this comment.
But then testing things locally is near impossible and the concourse pipeline is also more luck based than on the pinned resources.
There was a problem hiding this comment.
Locally you can link your repository folder to overwrite /alertmagnet and have everything in for testing.
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.