fix(comlink): handle heartbeat compatibility correctly #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of debugging I noticed that every time
@sanity/[email protected]sent achannel/heartbeatlike this:{ "connectionId": "46d4c484-df9c-4c7f-b633-d1739330567e", "domain": "sanity/channels", "from": "presentation", "id": "b9cf5be9-e64e-4efb-812b-4ace7c98c857", "to": "overlays", "type": "channel/heartbeat" }The connection was lost.
Comparing payloads and versions,
@sanity/[email protected]responds with:{ "connectionId": "46d4c484-df9c-4c7f-b633-d1739330567e", "data": { "responseTo": "b9cf5be9-e64e-4efb-812b-4ace7c98c857" }, "domain": "sanity/channels", "from": "overlays", "id": "b19f2420-e0d2-4156-9d36-982162129df2", "to": "presentation", "type": "channel/response" }And all is well.
While
@sanity/[email protected]responds with:{ "connectionId": "46d4c484-df9c-4c7f-b633-d1739330567e", "domain": "sanity/channels", "from": "overlays", "id": "msg-68f6d443-70e8-4306-abfb-9f2c6ee043e9", "to": "presentation", "type": "channel/response", "responseTo": "b9cf5be9-e64e-4efb-812b-4ace7c98c857" }The only difference I could find where:
{ "connectionId": "46d4c484-df9c-4c7f-b633-d1739330567e", - "data": { - "responseTo": "b9cf5be9-e64e-4efb-812b-4ace7c98c857" - }, "domain": "sanity/channels", "from": "overlays", "id": "b19f2420-e0d2-4156-9d36-982162129df2", "to": "presentation", "type": "channel/response", + "responseTo": "b9cf5be9-e64e-4efb-812b-4ace7c98c857" }I found the compat layer and tested the fix there, adding back
data.responseToif there were nodataalready, and also aresponseTopresent.@sanity/[email protected]can connect to both@sanity/[email protected]and@sanity/[email protected]without issues 😮💨