You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches submitted to the handleChange provided by DocumentPaneProvider are currently disallowed when the document is in a read-only state. This renders it impossible to unlink a Create-linked document, which relies on a patch being created programmatically.
This branch sidesteps the issue by excluding Create-linked documents from the read-only check.
What to review
handleChange may now patch any part of a Create-link document that would otherwise be read-only. Is this acceptable?
Testing
Unlink a Create-linked document.
Notes for release
Fixes a bug preventing Sanity Create documents from being unlinked.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
37ms
40ms
46ms
399ms
131ms
11.0s
article (body)
12ms
14ms
16ms
81ms
64ms
5.1s
article (string inside object)
36ms
37ms
40ms
213ms
120ms
6.8s
article (string inside array)
40ms
44ms
49ms
62ms
262ms
6.8s
recipe (name)
19ms
21ms
23ms
45ms
0ms
6.7s
recipe (description)
16ms
16ms
18ms
34ms
0ms
4.3s
recipe (instructions)
5ms
7ms
8ms
10ms
0ms
3.0s
synthetic (title)
50ms
53ms
63ms
347ms
817ms
12.9s
synthetic (string inside object)
51ms
53ms
57ms
385ms
1192ms
8.1s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
38ms
41ms
49ms
306ms
306ms
10.4s
article (body)
13ms
14ms
15ms
199ms
287ms
5.0s
article (string inside object)
36ms
40ms
44ms
136ms
151ms
6.5s
article (string inside array)
41ms
43ms
44ms
139ms
140ms
6.5s
recipe (name)
18ms
20ms
22ms
44ms
0ms
7.1s
recipe (description)
16ms
18ms
19ms
32ms
0ms
4.4s
recipe (instructions)
5ms
7ms
8ms
15ms
0ms
3.0s
synthetic (title)
52ms
56ms
77ms
327ms
1075ms
13.0s
synthetic (string inside object)
50ms
54ms
58ms
357ms
1240ms
8.3s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
juice49
changed the title
fix(sanity): accept patches to read-only Create-linked documents
fix(sanity): allow patching via handleChange in Create-linked documents
Feb 18, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patches submitted to the
handleChange
provided byDocumentPaneProvider
are currently disallowed when the document is in a read-only state. This renders it impossible to unlink a Create-linked document, which relies on a patch being created programmatically.This branch sidesteps the issue by excluding Create-linked documents from the read-only check.
What to review
handleChange
may now patch any part of a Create-link document that would otherwise be read-only. Is this acceptable?Testing
Unlink a Create-linked document.
Notes for release
Fixes a bug preventing Sanity Create documents from being unlinked.