Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): update managing permissions #8689

Closed
wants to merge 4 commits into from
Closed

refactor(core): update managing permissions #8689

wants to merge 4 commits into from

Conversation

RitaDias
Copy link
Contributor

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 2:23pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 2:23pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 2:23pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 2:23pm
test-next-studio ⬜️ Ignored (Inspect) Feb 18, 2025 2:23pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.94% 54813 / 127632
🔵 Statements 42.94% 54813 / 127632
🔵 Functions 48.07% 2787 / 5797
🔵 Branches 79.46% 10620 / 13365
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/perspective/navbar/ReleasesList.tsx 96.42% 88.88% 100% 96.42% 139-144
packages/sanity/src/core/releases/components/documentHeader/contextMenu/VersionContextMenu.tsx 100% 89.47% 100% 100%
packages/sanity/src/core/releases/tool/components/releaseCTAButtons/ReleasePublishAllButton.tsx 90.32% 91.66% 60% 90.32% 41, 97, 99-100, 180, 197-210
packages/sanity/src/core/releases/tool/components/releaseCTAButtons/ReleaseScheduleButton.tsx 67.23% 48% 50% 67.23% 72, 76-117, 134-137, 143-149, 156-178, 187-189, 239-244, 253-254, 257-258, 261-262
packages/sanity/src/core/releases/tool/detail/ReleaseDashboardDetails.tsx 94.37% 82% 66.66% 94.37% 58-60, 77-80, 94, 111, 139
packages/sanity/src/core/releases/tool/overview/ReleasesOverview.tsx 95.87% 86.58% 75% 95.87% 96, 137-138, 156, 172, 263-265, 272-276
Generated in workflow #30641 for commit 6d409a2 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 18, 2025

⚡️ Editor Performance Report

Updated Tue, 18 Feb 2025 14:28:55 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.3 efps (38ms) 25.0 efps (40ms) +2ms (+5.3%)
article (body) 75.2 efps (13ms) 69.9 efps (14ms) +1ms (-/-%)
article (string inside object) 27.0 efps (37ms) 25.0 efps (40ms) +3ms (+8.1%)
article (string inside array) 23.5 efps (43ms) 23.8 efps (42ms) -1ms (-1.2%)
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (description) 52.6 efps (19ms) 58.8 efps (17ms) -2ms (-10.5%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 21.3 efps (47ms) -4ms (-7.8%)
synthetic (string inside object) 19.8 efps (51ms) 19.6 efps (51ms) +1ms (+1.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 42ms 50ms 284ms 171ms 9.9s
article (body) 13ms 15ms 19ms 154ms 207ms 5.3s
article (string inside object) 37ms 39ms 42ms 195ms 174ms 6.5s
article (string inside array) 43ms 45ms 50ms 215ms 371ms 7.3s
recipe (name) 20ms 23ms 28ms 42ms 0ms 7.1s
recipe (description) 19ms 19ms 21ms 34ms 0ms 4.5s
recipe (instructions) 5ms 7ms 7ms 9ms 0ms 3.0s
synthetic (title) 51ms 56ms 60ms 262ms 780ms 13.2s
synthetic (string inside object) 51ms 54ms 70ms 452ms 1215ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 42ms 57ms 363ms 383ms 10.6s
article (body) 14ms 18ms 40ms 113ms 271ms 5.7s
article (string inside object) 40ms 43ms 50ms 145ms 254ms 7.0s
article (string inside array) 42ms 44ms 47ms 308ms 412ms 7.4s
recipe (name) 20ms 22ms 31ms 50ms 0ms 6.9s
recipe (description) 17ms 18ms 19ms 28ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 15ms 0ms 3.0s
synthetic (title) 47ms 53ms 63ms 226ms 548ms 12.6s
synthetic (string inside object) 51ms 53ms 63ms 309ms 643ms 7.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Component Testing Report Updated Feb 18, 2025 2:31 PM (UTC)

❌ Failed Tests (4) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 30s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 1s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 1m 2s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 1m 57s 14 0 1
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 49s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 3m 1s 20 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant