Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove activity panel borders #8680

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix(core): remove activity panel borders #8680

merged 1 commit into from
Feb 18, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Removes the activity panel borders to match with the prototype designs.

image

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner February 17, 2025 16:57
@pedrobonamin pedrobonamin requested a review from bjoerge February 17, 2025 16:57
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 5:03pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 5:03pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 5:03pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 17, 2025 5:03pm
test-next-studio ⬜️ Ignored (Inspect) Feb 17, 2025 5:03pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.75% 54381 / 127183
🔵 Statements 42.75% 54381 / 127183
🔵 Functions 48.09% 2787 / 5795
🔵 Branches 79.4% 10588 / 13334
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/tool/detail/ReleaseDashboardActivityPanel.tsx 36.06% 50% 100% 36.06% 38-82
Generated in workflow #30592 for commit 49fc137 by the Vitest Coverage Report Action

Copy link
Contributor

Component Testing Report Updated Feb 17, 2025 5:13 PM (UTC)

❌ Failed Tests (5) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 25s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 41s 3 0 3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 1m 0s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 1m 57s 14 0 1
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 53s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 20s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 40s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 17, 2025

⚡️ Editor Performance Report

Updated Mon, 17 Feb 2025 17:48:23 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.0 efps (40ms) 28.6 efps (35ms) -5ms (-12.5%)
article (body) 84.0 efps (12ms) 76.9 efps (13ms) +1ms (-/-%)
article (string inside object) 28.6 efps (35ms) 28.6 efps (35ms) +0ms (-/-%)
article (string inside array) 25.0 efps (40ms) 25.6 efps (39ms) -1ms (-2.5%)
recipe (name) 50.0 efps (20ms) 43.5 efps (23ms) +3ms (+15.0%)
recipe (description) 58.8 efps (17ms) 47.6 efps (21ms) +4ms (+23.5%) 🔴
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.0 efps (50ms) 20.2 efps (50ms) -1ms (-1.0%)
synthetic (string inside object) 20.4 efps (49ms) 20.8 efps (48ms) -1ms (-2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 45ms 62ms 479ms 887ms 10.5s
article (body) 12ms 15ms 19ms 190ms 221ms 5.0s
article (string inside object) 35ms 39ms 43ms 148ms 239ms 7.1s
article (string inside array) 40ms 42ms 44ms 237ms 164ms 7.1s
recipe (name) 20ms 22ms 27ms 38ms 0ms 7.1s
recipe (description) 17ms 18ms 21ms 34ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 23ms 0ms 3.1s
synthetic (title) 50ms 53ms 63ms 317ms 1059ms 12.5s
synthetic (string inside object) 49ms 52ms 62ms 432ms 913ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 35ms 39ms 44ms 72ms 718ms 10.0s
article (body) 13ms 15ms 17ms 252ms 290ms 5.3s
article (string inside object) 35ms 39ms 46ms 224ms 359ms 6.9s
article (string inside array) 39ms 41ms 44ms 244ms 256ms 6.7s
recipe (name) 23ms 25ms 29ms 38ms 0ms 7.6s
recipe (description) 21ms 22ms 27ms 47ms 1ms 5.1s
recipe (instructions) 5ms 6ms 7ms 19ms 0ms 3.2s
synthetic (title) 50ms 52ms 57ms 226ms 491ms 11.8s
synthetic (string inside object) 48ms 51ms 62ms 119ms 569ms 7.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 82c995d into next Feb 18, 2025
62 checks passed
@pedrobonamin pedrobonamin deleted the sapp-2086 branch February 18, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants