fix(core): add permission limitation for create release #8623

RitaDias · 2025-02-13T12:56:44Z

Description

Prevent create release

In Global Menu
In document headers
In the release list

Discard version discard

Prevent discard version in document header

What to review

Anything could be improved?

Testing

The existing test should be enough.
Can manually test by following the screenshots

Notes for release

Discard version and create releases action menus and buttons for releases now respect permissions.

vercel · 2025-02-13T12:56:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 2:16pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 2:16pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 2:16pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 14, 2025 2:16pm
test-next-studio	⬜️ Ignored (Inspect)			Feb 14, 2025 2:16pm

github-actions · 2025-02-13T13:01:51Z

No changes to documentation

github-actions · 2025-02-13T13:09:48Z

⚡️ Editor Performance Report

Updated Fri, 14 Feb 2025 14:22:12 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	27.0 efps (37ms)	25.6 efps (39ms)	+2ms (+5.4%)	✅
article (body)	73.0 efps (14ms)	77.8 efps (13ms)	-1ms (-/-%)	✅
article (string inside object)	27.0 efps (37ms)	27.4 efps (37ms)	-1ms (-1.4%)	✅
article (string inside array)	24.4 efps (41ms)	24.4 efps (41ms)	+0ms (-/-%)	✅
recipe (name)	52.6 efps (19ms)	52.6 efps (19ms)	+0ms (-/-%)	✅
recipe (description)	62.5 efps (16ms)	58.8 efps (17ms)	+1ms (+6.3%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	20.0 efps (50ms)	20.4 efps (49ms)	-1ms (-2.0%)	✅
synthetic (string inside object)	20.2 efps (50ms)	21.3 efps (47ms)	-3ms (-5.1%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	37ms	41ms	56ms	477ms	755ms	10.2s
article (body)	14ms	15ms	23ms	101ms	219ms	5.1s
article (string inside object)	37ms	39ms	44ms	143ms	127ms	6.6s
article (string inside array)	41ms	42ms	45ms	145ms	265ms	7.1s
recipe (name)	19ms	20ms	24ms	37ms	0ms	7.2s
recipe (description)	16ms	17ms	19ms	28ms	0ms	4.4s
recipe (instructions)	5ms	6ms	8ms	10ms	0ms	3.0s
synthetic (title)	50ms	51ms	58ms	218ms	553ms	12.6s
synthetic (string inside object)	50ms	55ms	62ms	207ms	908ms	8.3s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	39ms	43ms	66ms	435ms	334ms	10.5s
article (body)	13ms	15ms	19ms	137ms	207ms	5.5s
article (string inside object)	37ms	40ms	45ms	81ms	114ms	6.5s
article (string inside array)	41ms	43ms	47ms	60ms	139ms	6.8s
recipe (name)	19ms	21ms	26ms	41ms	0ms	7.2s
recipe (description)	17ms	18ms	19ms	34ms	0ms	4.3s
recipe (instructions)	5ms	6ms	7ms	21ms	0ms	3.1s
synthetic (title)	49ms	52ms	62ms	355ms	823ms	12.5s
synthetic (string inside object)	47ms	51ms	92ms	537ms	982ms	8.4s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

github-actions · 2025-02-13T13:11:11Z

Component Testing Report Updated Feb 14, 2025 2:23 PM (UTC)

❌ Failed Tests (2) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 10s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	1m 57s	4	0	2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	54s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	15s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 7s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 38s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	2m 5s	21	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 45s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

fix(core): add permission limitation for create release in releases overview

github-actions · 2025-02-14T07:36:29Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.71%	54276 / 127064
🔵	Statements	42.71%	54276 / 127064
🔵	Functions	48.08%	2785 / 5792
🔵	Branches	79.28%	10524 / 13273

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/i18n/bundles/studio.ts	100%	100%	100%	100%
packages/sanity/src/core/perspective/navbar/ReleasesList.tsx	96.26%	88%	100%	96.26%	131-136
packages/sanity/src/core/releases/components/dialog/CreateReleaseDialog.tsx	78.5%	100%	100%	78.5%	55-62, 76-90
packages/sanity/src/core/releases/components/documentHeader/VersionChip.tsx	77.7%	35.48%	15.38%	77.7%	56, 128-130, 135-136, 145-146, 154, 164-165, 175-188, 248-255, 260-270
packages/sanity/src/core/releases/components/documentHeader/contextMenu/VersionContextMenu.tsx	100%	89.09%	100%	100%
packages/sanity/src/core/releases/tool/overview/ReleasesOverview.tsx	95.79%	86.25%	75%	95.79%	96, 130-131, 149, 165, 256-258, 265-269
packages/sanity/src/core/releases/util/const.ts	100%	100%	100%	100%
packages/sanity/src/ui-components/menuGroup/MenuGroup.tsx	100%	83.33%	100%	100%

Generated in workflow #30408 for commit a6c94fc by the Vitest Coverage Report Action

…verview

…icker

…nt picker

jordanl17

Looking good @RitaDias - just added in a couple of comments. Would be interested to know what you think on managing the permission state inside useReleasePermissions

packages/sanity/src/core/perspective/navbar/ReleasesList.tsx

packages/sanity/src/core/perspective/navbar/__tests__/ReleasesNav.test.tsx

packages/sanity/src/core/releases/components/documentHeader/contextMenu/VersionContextMenu.tsx

packages/sanity/src/core/releases/tool/overview/ReleasesOverview.tsx

packages/sanity/test/mocks/useDocumentPairPermissions.mock.ts

jordanl17

Thanks

jordanl17 · 2025-02-14T14:25:35Z

packages/sanity/src/core/perspective/navbar/__tests__/ReleasesList.test.tsx

+        ...useActiveReleasesMockReturn,
+        data: [activeASAPRelease, activeScheduledRelease, activeUndecidedRelease],
+      })
+      mockUseReleasePermissions.mockReturnValue({


vercel bot deployed to Preview – test-studio February 13, 2025 13:04 View deployment

vercel bot deployed to Preview – performance-studio February 13, 2025 13:06 View deployment

vercel bot deployed to Preview – page-building-studio February 13, 2025 13:06 View deployment

RitaDias force-pushed the sapp-2112-2 branch from d92104b to 11ac33c Compare February 13, 2025 13:26

vercel bot deployed to Preview – test-studio February 13, 2025 13:34 View deployment

vercel bot deployed to Preview – performance-studio February 13, 2025 13:35 View deployment

vercel bot deployed to Preview – page-building-studio February 13, 2025 13:36 View deployment

RitaDias force-pushed the sapp-2112-2 branch 2 times, most recently from 9f05dcc to 037cf66 Compare February 13, 2025 13:55

vercel bot deployed to Preview – test-studio February 13, 2025 14:04 View deployment

vercel bot deployed to Preview – performance-studio February 13, 2025 14:06 View deployment

vercel bot deployed to Preview – page-building-studio February 13, 2025 14:06 View deployment

fix(core): add permission limitation for create release in global picker

17676f1

fix(core): add permission limitation for create release in releases overview

RitaDias force-pushed the sapp-2112-2 branch from 97ea691 to 17676f1 Compare February 14, 2025 07:30

vercel bot deployed to Preview – page-building-studio February 14, 2025 07:37 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 07:37 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 07:39 View deployment

fix(core): add permission limitation for create release in releases o…

cb931ad

…verview

vercel bot deployed to Preview – page-building-studio February 14, 2025 08:02 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 08:03 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 08:03 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 08:20 View deployment

vercel bot deployed to Preview – page-building-studio February 14, 2025 08:20 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 08:21 View deployment

fix(core): add permission limitation for create release in document p…

3524672

…icker

RitaDias force-pushed the sapp-2112-2 branch from b186a3a to 3524672 Compare February 14, 2025 08:29

vercel bot deployed to Preview – page-building-studio February 14, 2025 08:35 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 08:35 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 08:36 View deployment

fix(core): add permission limitation for discarding version in docume…

2c086d6

…nt picker

vercel bot deployed to Preview – page-building-studio February 14, 2025 09:41 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 09:41 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 09:42 View deployment

RitaDias marked this pull request as ready for review February 14, 2025 10:00

RitaDias requested review from a team as code owners February 14, 2025 10:00

RitaDias requested a review from jordanl17 February 14, 2025 10:00

jordanl17 requested changes Feb 14, 2025

View reviewed changes

refactor(core): tooltips set up with disabled

cc6c698

vercel bot deployed to Preview – page-building-studio February 14, 2025 12:27 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 12:27 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 12:28 View deployment

test(core): add permision check for releasesNAv

437bcf2

jordanl17 previously approved these changes Feb 14, 2025

View reviewed changes

test(core): add releasesList test

a6c94fc

RitaDias dismissed jordanl17’s stale review via a6c94fc February 14, 2025 14:09

vercel bot deployed to Preview – page-building-studio February 14, 2025 14:15 View deployment

vercel bot deployed to Preview – performance-studio February 14, 2025 14:16 View deployment

vercel bot deployed to Preview – test-studio February 14, 2025 14:16 View deployment

RitaDias requested a review from jordanl17 February 14, 2025 14:25

jordanl17 approved these changes Feb 14, 2025

View reviewed changes

RitaDias merged commit 70a58cb into next Feb 14, 2025
62 checks passed

RitaDias deleted the sapp-2112-2 branch February 14, 2025 14:25

jordanl17 reviewed Feb 14, 2025

View reviewed changes

EoinFalconer pushed a commit that referenced this pull request Feb 16, 2025

fix(core): add permission limitation for create release (#8623)

e4188c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): add permission limitation for create release #8623

fix(core): add permission limitation for create release #8623

RitaDias commented Feb 13, 2025 •

edited

Loading

vercel bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025

github-actions bot commented Feb 13, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

jordanl17 left a comment

jordanl17 left a comment

jordanl17 Feb 14, 2025

fix(core): add permission limitation for create release #8623

fix(core): add permission limitation for create release #8623

Conversation

RitaDias commented Feb 13, 2025 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 13, 2025

github-actions bot commented Feb 13, 2025 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

github-actions bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 14, 2025 • edited Loading

Coverage Report

jordanl17 left a comment

Choose a reason for hiding this comment

jordanl17 left a comment

Choose a reason for hiding this comment

jordanl17 Feb 14, 2025

Choose a reason for hiding this comment

RitaDias commented Feb 13, 2025 •

edited

Loading

vercel bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading