fix(releases): blocking UI elements that allow for adding documents to inactive releases #7879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Dec 6, 2024 2:20 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Fri, 06 Dec 2024 14:22:56 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
bjoerge
force-pushed
the
corel
branch
2 times, most recently
from
2a7e87e to
229ecf3
Compare
…o inactive releases
jordanl17
force-pushed
the
corel-270-disable-non-active-release-add
branch
from
3097e4c to
5edf238
Compare
jordanl17
requested review from
pedrobonamin,
bjoerge,
juice49 and
RitaDias
and removed request for
a team
bjoerge
reviewed
Dec 6, 2024
| import {usePerspective} from './usePerspective' | ||
|
|
||
| /** @internal */ | ||
| export const useIsReleaseActive = () => { |
There was a problem hiding this comment.
very much a nit, but I think we tend to use/prefer named functions
bjoerge
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if you are in published perspective or a scheduled release perspective, trying to add a new release in studio will show a new draft has been created but will be read only. The global perspective will remain as published or scheduled release even though the document form is showing a draft.
This change disables the UI elements that allow for creating documents in these scenarios.
NOTE: currently the tooltip clarification is the same for published as it is for a scheduled release. This should probably be made clearer to avoid confusion by separating these 2 scenarios, but I'd rather get this initial change in, and can then follow up once the copy has been confirmed later.
What to review
Testing
There aren't currently any tests for these components or for their parents, so adding testing coverage here is a larger task
Notes for release
N/A