fix(structure): allow search/list ignored types when explicitly requested #6771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We previously allowed users to list assets in the structure tool by using a
S.documentTypeList('sanity.imageAsset')
, but during search refactoring this seems to no longer be possible.This reintroduces the ability, by ensuring that the
getSearchableTypes()
does not remove explicitly declared types.What to review
next
, the document list underCustom panes > Images
does not list images, and that the preview deploy of this doesTesting
I attempted to test the actual
listenSearchQuery()
function, but it has a lot of dependencies and was not easy to mock out a client for. An alternative would be to do an e2e test, but I would prefer us to have a more stable environment we can test against, to ensure we have assets that can be listed. I'll make a note of it for future iterations of the E2E suite.For now, I added some tests for the
getSearchableTypes
function, which at least increases test coverage of that part of the codebase.Notes for release