Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): collapsed range decorations #6568

Merged
merged 4 commits into from
May 6, 2024
Merged

fix(core): collapsed range decorations #6568

merged 4 commits into from
May 6, 2024

Conversation

hermanwikner
Copy link
Member

Description

What to review

Testing

Notes for release

@vercel Vercel
Copy link

vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 6, 2024 11:59am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 11:59am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 11:59am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 11:59am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

Component Testing Report Updated May 6, 2024 12:03 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 19s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

@hermanwikner hermanwikner force-pushed the fix/pte-decoration-collpased-bug branch from 368fd5d to 8b66494 Compare May 6, 2024 07:18
@hermanwikner hermanwikner marked this pull request as ready for review May 6, 2024 07:24
@hermanwikner hermanwikner requested review from a team, ninaandal and skogsmaskin and removed request for a team and ninaandal May 6, 2024 07:24
@hermanwikner hermanwikner force-pushed the fix/pte-decoration-collpased-bug branch from 8b66494 to eb05e3a Compare May 6, 2024 11:09
skogsmaskin
skogsmaskin approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@hermanwikner hermanwikner added this pull request to the merge queue May 6, 2024
Merged via the queue into next with commit 70ab283 May 6, 2024
29 of 35 checks passed
@hermanwikner hermanwikner deleted the fix/pte-decoration-collpased-bug branch May 6, 2024 11:59
This was referenced May 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanwikner @skogsmaskin