fix(sanity): do not order by _updatedAt when relevance ordering is used with Text Search API search strategy
#6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used with Text Search API search strategy
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No changes to documentation |
juice49
changed the title
_updatedAt when relevance ordering is used with Text Search API search strategy
|
Component Testing Report Updated May 2, 2024 8:18 AM (UTC)
|
juice49
requested review from
a team,
jordanl17 and
ricokahler
and removed request for
a team
juice49
force-pushed
the
fix/sdx-1310-global-search-relevance-order
branch
from
ee967b4 to
a01532d
Compare
jordanl17
reviewed
May 2, 2024
packages/sanity/src/core/studio/components/navbar/search/contexts/search/SearchProvider.tsx
Show resolved
Hide resolved
jordanl17
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch relates only to global search.
Ordering by relevance ("best match") when using the GROQ Query API search strategy causes the order
{direction: 'desc', field: '_updatedAt'}to be applied. This is correct, because the results are subsequently ordered client-side.However, this is incorrect when using the Text Search API search strategy. The Text Search API yields results ordered by relevance by default, and we do not apply any client-side ordering.
This branch eliminates the incorrectly applied
{direction: 'desc', field: '_updatedAt'}ordering when the Text Search API search strategy is used.What to review
order(_updatedAt desc)is still present in the GROQ Query API request when ordering by relevance using the GROQ Query API search strategy.{order: [{"attribute": "_updatedAt", "direction": "desc"}]is not present in the Text Search API request when ordering by relevance using the Text Search API search strategy.Testing
Added unit tests to
packages/sanity/src/core/studio/components/navbar/search/contexts/search/reducer.test.ts.