Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(i18n): fix imports for useTranslation #6517

Merged
merged 2 commits into from
May 2, 2024
Merged

chore(i18n): fix imports for useTranslation #6517

merged 2 commits into from
May 2, 2024

Conversation

jtpetty
Copy link
Contributor

@jtpetty jtpetty commented Apr 29, 2024

Description

Fixes SDX-1230

No visual changes. This PR just updates where useTranslation is imported from.

What to review

Did I miss anything?

Testing

No functional change, so no test changes needed.

@jtpetty jtpetty requested a review from a team April 29, 2024 18:50
@jtpetty jtpetty requested a review from a team as a code owner April 29, 2024 18:50
@jtpetty jtpetty requested review from sjelfull and cngonzalez and removed request for a team April 29, 2024 18:50
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 29, 2024 7:15pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 7:15pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 7:15pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 7:15pm

@jtpetty jtpetty requested a review from rexxars April 29, 2024 18:51
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

Component Testing Report Updated Apr 29, 2024 7:17 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 6s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

cngonzalez
cngonzalez approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@cngonzalez cngonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! i can revisit bumping our eslint rules for i18n now :)

@jtpetty jtpetty added this pull request to the merge queue May 2, 2024
Merged via the queue into next with commit 869b698 May 2, 2024
38 of 39 checks passed
@jtpetty jtpetty deleted the sdx-1230 branch May 2, 2024 15:45
This was referenced May 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cngonzalez cngonzalez cngonzalez approved these changes

@sjelfull sjelfull Awaiting requested review from sjelfull

@rexxars rexxars Awaiting requested review from rexxars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpetty @cngonzalez