fix(tasks): close the form only after the task is created

[pedrobonamin]

Description

Fixes an issue in which tasks are kept in draft mode after clicking on the "create" button.
The on change action triggered by the form doesn't provides a way to validate that the transaction ended, so in this case we will persist the form in creating state until the task store is updated with the correct values.
The task store fetches the latest task values when a task is updated, so if the value has been updated in the store it means the transaction has ended.

What to review

Is there a better way to do this?
Is there any way to access the transaction from the form onChange or from any form action?

Testing

Notes for release

fixes an issue in tasks in which the UI showed that they were created but the transaction was didn't ended.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Apr 30, 2024 2:04pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2024 2:04pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2024 2:04pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Apr 30, 2024 2:04pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Apr 30, 2024 2:08 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	35s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	20s	6	3	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	14s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	35s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 3s	15	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 5s	18	0	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	20s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	14s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	22s	9	0	0

[sjelfull]

Thanks! Would prefer if we could re-use useDocumentOperationEvent here. That will give us a more solid way to handle the create lifecycle here. You can see an example of this within the DocumentOperationResults component.

[pedrobonamin]

@sjelfull dismissing the review given the Pr has been approved and I want to have this merged for tomorrows release, happy to revert later or address the suggestions if you have any, but I think they have been answered and covered with the last changes.

@sjelfull dismissing the review given the Pr has been approved and I want to have this merged for tomorrows release, happy to revert later or address the suggestions if you have any, but I think they have been answered and covered with the last changes.