fix(core): change design for clickable present users in dropdown #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hermanwikner
reviewed
Feb 3, 2023
packages/sanity/src/core/studio/components/navbar/presence/PresenceMenuItem.tsx
Outdated
Show resolved
Hide resolved
hermanwikner
reviewed
Feb 3, 2023
packages/sanity/src/core/studio/components/navbar/presence/PresenceMenu.tsx
Outdated
Show resolved
Hide resolved
ninaandal
force-pushed
the
bug/sc-29587/edit-avatar-pull-down-to-show-clickable-avatars
branch
from
0244b03 to
701bd7f
Compare
hermanwikner
reviewed
Feb 6, 2023
packages/sanity/src/core/studio/components/navbar/presence/PresenceMenuItem.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/studio/components/navbar/presence/PresenceMenu.tsx
Outdated
Show resolved
Hide resolved
ninaandal
deleted the
bug/sc-29587/edit-avatar-pull-down-to-show-clickable-avatars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The LinkIcon for clickable users in the presence menu has been replaced with a new design. The users that are not clickable are now greyed out and has text under. Users that can be clicked on, are not.
What to review
Click on the presence menu and make sure users that have a presence can be clicked on.
Notes for release
Design change of the presence menu where non-clickable users are greyed out