refactor: use named export for schema package #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
rexxars
force-pushed
the
refactor/schema-named-export
branch
from
0a21d76 to
1746698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to move away from default exports, as they are hard to work with in a dual CommonJS/ESM environment. The schema package currently only exposes the
Schemaclass on the default export. This PR moves the default Schema class export to a named export (Schema), and introduces a "deprecated" class for the default export, which only exists to warn about the deprecated default export.I decided to warn with a stack trace to make it easier to find where the warning is appearing from.
Notes for release
@sanity/schemamodule - the default export is now deprecated and will give a warning when used