chore: use playwright for e2e tests #3145
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). studio-workshop – ./dev/workshop🔍 Inspect: https://vercel.com/sanity-io/studio-workshop/4adC3cSrYmahoVq9UTUfCzovJiL8 test-studio – ./🔍 Inspect: https://vercel.com/sanity-io/test-studio/9QXa2G8zLQNvC116N6wSNhDmTuQr perf-studio – ./🔍 Inspect: https://vercel.com/sanity-io/perf-studio/2ftRdz6BNhoMhAmRPzgVedKVaJJe |
| await Promise.all([ | ||
| page.goto('test/desk/'), | ||
| page.locator('data-testid=default-layout-global-create-button').click(), | ||
| page.locator('data-testid=create-document-item-book-by-author').click(), | ||
| ]) |
There was a problem hiding this comment.
Is this the recommended way of doing this in playwright? I feel like all of these depend on eachother and that a sequence of await would read better - but maybe this is slightly faster?
playwright/helpers/sanityClient.ts
Outdated
| export async function deleteDocument(payload) { | ||
| return testSanityClient.delete(payload) | ||
| } |
There was a problem hiding this comment.
I feel like we can just as well use testSanityClient.delete() directly to get more control of the operation (second argument, for instance), or have this function do something more specific, eg function deleteDocumentsForRun(typeName: string), which could generate a GROQ query with the correct type name and run ID. Thoughts?
There was a problem hiding this comment.
I like that, a more specific one! Will add
vicmeow
force-pushed
the
chore/sc-13478/improve-test-coverage
branch
from
e67008e to
fe2306d
Compare
mariuslundgard
force-pushed
the
next
branch
2 times, most recently
from
2329225 to
7eb6574
Compare
|
Closing this as #4143 has now landed, but will leave the branch around in case we might need it. |
Description
What to review
Notes for release