add handler name to request as endpoint #979
Conversation
| ## Accessing the handler name with the request.endpoint attribute | ||
|
|
||
| The `request.endpoint` attribute holds the handler's name. For instance, the below | ||
| route will return "hello". |
There was a problem hiding this comment.
I think in a blueprint, it should also include the blueprint's name? For example: foo.hello, bar.hello
|
@messense if you see a better way of implementing this with the blueprint name, let me know. I'm not fond of the if statement, as it will be executed on each request. |
|
Can we make |
| @@ -247,6 +247,12 @@ def websocket(self, uri, host=None, strict_slashes=None, | |||
| def response(handler): | |||
| async def websocket_handler(request, *args, **kwargs): | |||
| request.app = self | |||
| if not getattr(handler, '__blueprintname__', False): | |||
There was a problem hiding this comment.
will you please make this (and used in converted_response_type) portion a function.
Also I would drop 'else' statement there, so it looks like:
def _get_endpoint(handler):
if not getattr(handler, '__blueprintname__', False):
return handler.__name__
return getattr(handler,
'__blueprintname__',
'') + handler.__name__
and used as
request.endpoint = _get_endpoint(handler)
|
@r0fls Are we keeping this? Can you either update to resolve conflicts or close it? |
|
I updated this PR to current master, made a few tweaks, added some tests, but was not allowed to push to this branch. Therefore, I am closing and will submit a new PR. |
Fixes: #977