Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatible type annotation of get method in the HTTPMethodView class #3016

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Fix incompatible type annotation of get method in the HTTPMethodView class #3016

merged 3 commits into from
Dec 22, 2024

Conversation

ChihweiLHBird
Copy link
Member

Resolves #2916

Use getattr to try getting the get handler to avoid the typing annotation incompatibility issue.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner December 18, 2024 08:59
@ChihweiLHBird ChihweiLHBird changed the title Remove incompatible type annotation of get method in the HTTPMethodView class Fix incompatible type annotation of get method in the HTTPMethodView class Dec 18, 2024
ahopkins
ahopkins reviewed Dec 22, 2024
View reviewed changes
sanic/views.py Outdated Show resolved Hide resolved
@ahopkins ahopkins merged commit 0d34d1c into main Dec 22, 2024
25 checks passed
@ahopkins ahopkins deleted the zhiwei/http-view-get-typing branch December 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy error type for async get function in HTTPMethodView
2 participants
@ChihweiLHBird @ahopkins