Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static dir 2075 #2076

Merged
merged 3 commits into from
Mar 21, 2021
Merged

Static dir 2075 #2076

merged 3 commits into from
Mar 21, 2021

Conversation

ahopkins
Copy link
Member

Fixes #2075

@mikekeda This should solve the problem.

@ahopkins ahopkins requested review from a team as code owners March 21, 2021 12:31
@ahopkins
Copy link
Member Author

When merged, should be released as 21.3.1

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #2076 (ccb2d46) into master (13630a7) will increase coverage by 0.057%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #2076       +/-   ##
=============================================
+ Coverage   92.184%   92.241%   +0.057%     
=============================================
  Files           38        38               
  Lines         3480      3480               
  Branches       582       582               
=============================================
+ Hits          3208      3210        +2     
+ Misses         184       183        -1     
+ Partials        88        87        -1     
Impacted Files Coverage Δ
sanic/__version__.py 100.000% <100.000%> (ø)
sanic/mixins/routes.py 94.898% <100.000%> (ø)
sanic/app.py 92.623% <0.000%> (+0.410%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13630a7...ccb2d46. Read the comment docs.

sjsadowski
sjsadowski previously approved these changes Mar 21, 2021
Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change. LGTM.

@ahopkins ahopkins requested a review from sjsadowski March 21, 2021 12:48
@ahopkins ahopkins merged commit 938d2b5 into master Mar 21, 2021
@ahopkins ahopkins deleted the static-dir-2075 branch March 21, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static files inside subfolders are not accessible (404)
2 participants