Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIT-2045: enable versioning and strict slash on BlueprintGroup #2047

Conversation

harshanarayana
Copy link
Contributor

@harshanarayana harshanarayana commented Mar 6, 2021

closes #2045

  • Unit Tests
  • Update Documentation

@harshanarayana harshanarayana requested a review from ahopkins March 6, 2021 19:46
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #2047 (2c4cb55) into master (be905e0) will increase coverage by 0.124%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #2047       +/-   ##
=============================================
+ Coverage   91.857%   91.981%   +0.124%     
=============================================
  Files           35        36        +1     
  Lines         3242      3292       +50     
  Branches       556       559        +3     
=============================================
+ Hits          2978      3028       +50     
  Misses         179       179               
  Partials        85        85               
Impacted Files Coverage Δ
sanic/websocket.py 82.418% <ø> (ø)
sanic/app.py 91.379% <100.000%> (+0.019%) ⬆️
sanic/blueprint_group.py 100.000% <100.000%> (ø)
sanic/blueprints.py 100.000% <100.000%> (ø)
sanic/handlers.py 95.455% <100.000%> (-0.464%) ⬇️
sanic/models/futures.py 100.000% <100.000%> (ø)
sanic/models/handler_types.py 100.000% <100.000%> (ø)
sanic/router.py 94.667% <100.000%> (ø)
sanic/server.py 87.958% <100.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be905e0...2c4cb55. Read the comment docs.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add test coverage 😎 

sanic/blueprint_group.py Outdated Show resolved Hide resolved
sanic/blueprint_group.py Outdated Show resolved Hide resolved
sanic/blueprint_group.py Outdated Show resolved Hide resolved
@harshanarayana harshanarayana force-pushed the feature/GIT-2045-enable-versioning-blueprint-grpup branch from 77eac4a to 1a5bdc5 Compare March 7, 2021 06:35
@harshanarayana harshanarayana marked this pull request as ready for review March 7, 2021 06:43
@harshanarayana harshanarayana requested review from ahopkins and a team March 7, 2021 06:49
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this.

sanic/blueprint_group.py Outdated Show resolved Hide resolved
sanic/blueprints.py Outdated Show resolved Hide resolved
sanic/models/futures.py Show resolved Hide resolved
sanic/models/futures.py Outdated Show resolved Hide resolved
sanic/models/futures.py Outdated Show resolved Hide resolved
sanic/models/futures.py Outdated Show resolved Hide resolved
sanic/models/futures.py Outdated Show resolved Hide resolved
sanic/models/futures.py Outdated Show resolved Hide resolved
tests/test_blueprints.py Outdated Show resolved Hide resolved
tests/test_blueprints.py Outdated Show resolved Hide resolved
@harshanarayana harshanarayana requested review from ahopkins and a team March 7, 2021 09:49
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple more minor changes.

examples/versioned_blueprint_group.py Outdated Show resolved Hide resolved
sanic/blueprint_group.py Outdated Show resolved Hide resolved
tests/benchmark/test_route_resolution_benchmark.py Outdated Show resolved Hide resolved
tests/test_blueprints.py Outdated Show resolved Hide resolved
tests/test_blueprints.py Show resolved Hide resolved
@harshanarayana harshanarayana requested a review from ahopkins March 7, 2021 12:08
sanic/blueprint_group.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@harshanarayana harshanarayana requested a review from ahopkins March 7, 2021 12:24
@harshanarayana harshanarayana force-pushed the feature/GIT-2045-enable-versioning-blueprint-grpup branch from fd221e0 to c6b1129 Compare March 7, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning in the Blueprint Group
2 participants